Conversation
it is not needed for building with nix, and causes more confusion than is helpful (see `git log -p -- vendor/wasm-spec`).
rossberg
approved these changes
Feb 1, 2019
Contributor
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Can't claim to understand all the implications, but LGTM.
dfinity-bot
added a commit
that referenced
this pull request
Jul 18, 2020
## Changelog for motoko-base: Branch: next-moc Commits: [caffeinelabs/motoko-base@27b7d097...0375b45d](caffeinelabs/motoko-base@27b7d09...0375b45) * [`f9f5de90`](caffeinelabs/motoko-base@f9f5de9) Revert "Remove WordN.toInt ([dfinity-lab/motoko-base#125](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/125))" and reimplement ([dfinity-lab/motoko-base#137](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/137)) * [`09f2f2ec`](caffeinelabs/motoko-base@09f2f2e) Push built documentation to GH pages ([dfinity-lab/motoko-base#78](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/78)) * [`b15c0a0d`](caffeinelabs/motoko-base@b15c0a0) Docs for TrieMap module ([dfinity-lab/motoko-base#128](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/128)) * [`012bacec`](caffeinelabs/motoko-base@012bace) Document more of Trie module; clean up. ([dfinity-lab/motoko-base#130](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/130)) * [`f635a5c7`](caffeinelabs/motoko-base@f635a5c) Document TrieSet module ([dfinity-lab/motoko-base#139](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/139)) * [`08f167de`](caffeinelabs/motoko-base@08f167d) doc comments ([dfinity-lab/motoko-base#141](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/141))
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2020
## Changelog for motoko-base: Branch: next-moc Commits: [caffeinelabs/motoko-base@27b7d097...0375b45d](caffeinelabs/motoko-base@27b7d09...0375b45) * [`f9f5de90`](caffeinelabs/motoko-base@f9f5de9) Revert "Remove WordN.toInt ([dfinity-lab/motoko-base#125](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/125))" and reimplement ([dfinity-lab/motoko-base#137](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/137)) * [`09f2f2ec`](caffeinelabs/motoko-base@09f2f2e) Push built documentation to GH pages ([dfinity-lab/motoko-base#78](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/78)) * [`b15c0a0d`](caffeinelabs/motoko-base@b15c0a0) Docs for TrieMap module ([dfinity-lab/motoko-base#128](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/128)) * [`012bacec`](caffeinelabs/motoko-base@012bace) Document more of Trie module; clean up. ([dfinity-lab/motoko-base#130](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/130)) * [`f635a5c7`](caffeinelabs/motoko-base@f635a5c) Document TrieSet module ([dfinity-lab/motoko-base#139](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/139)) * [`08f167de`](caffeinelabs/motoko-base@08f167d) doc comments ([dfinity-lab/motoko-base#141](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/141))
dfinity-bot
added a commit
that referenced
this pull request
Nov 18, 2020
## Changelog for candid: Branch: Commits: [dfinity/candid@d768917c...30f719fa](dfinity/candid@d768917...30f719f) * [`30f719fa`](dfinity/candid@30f719f) Opt subtyping: Restrict going via constituent rule ([dfinity/candid#137](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/137))
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2020
## Changelog for candid: Branch: Commits: [dfinity/candid@d768917c...30f719fa](dfinity/candid@d768917...30f719f) * [`30f719fa`](dfinity/candid@30f719f) Opt subtyping: Restrict going via constituent rule ([dfinity/candid#137](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/137))
dfinity-bot
added a commit
that referenced
this pull request
Feb 2, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...ebedfe6e](dfinity/ic-hs@2c9f2ea...ebedfe6) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs#135](https://github.com/dfinity/ic-hs/issues/135)) * [`e29764e9`](dfinity/ic-hs@e29764e) fix conditions on read_state requests ([dfinity/ic-hs#136](https://github.com/dfinity/ic-hs/issues/136)) * [`ebedfe6e`](dfinity/ic-hs@ebedfe6) make nonexisting canister id in the subnet's ranges ([dfinity/ic-hs#137](https://github.com/dfinity/ic-hs/issues/137))
dfinity-bot
added a commit
that referenced
this pull request
Feb 3, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...80875f3a](dfinity/ic-hs@2c9f2ea...80875f3) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs#135](https://github.com/dfinity/ic-hs/issues/135)) * [`e29764e9`](dfinity/ic-hs@e29764e) fix conditions on read_state requests ([dfinity/ic-hs#136](https://github.com/dfinity/ic-hs/issues/136)) * [`ebedfe6e`](dfinity/ic-hs@ebedfe6) make nonexisting canister id in the subnet's ranges ([dfinity/ic-hs#137](https://github.com/dfinity/ic-hs/issues/137)) * [`80875f3a`](dfinity/ic-hs@80875f3) increase error msg length limit ([dfinity/ic-hs#139](https://github.com/dfinity/ic-hs/issues/139))
dfinity-bot
added a commit
that referenced
this pull request
Feb 5, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...80875f3a](dfinity/ic-hs@2c9f2ea...80875f3) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs#135](https://github.com/dfinity/ic-hs/issues/135)) * [`e29764e9`](dfinity/ic-hs@e29764e) fix conditions on read_state requests ([dfinity/ic-hs#136](https://github.com/dfinity/ic-hs/issues/136)) * [`ebedfe6e`](dfinity/ic-hs@ebedfe6) make nonexisting canister id in the subnet's ranges ([dfinity/ic-hs#137](https://github.com/dfinity/ic-hs/issues/137)) * [`80875f3a`](dfinity/ic-hs@80875f3) increase error msg length limit ([dfinity/ic-hs#139](https://github.com/dfinity/ic-hs/issues/139))
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...80875f3a](dfinity/ic-hs@2c9f2ea...80875f3) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs#135](https://github.com/dfinity/ic-hs/issues/135)) * [`e29764e9`](dfinity/ic-hs@e29764e) fix conditions on read_state requests ([dfinity/ic-hs#136](https://github.com/dfinity/ic-hs/issues/136)) * [`ebedfe6e`](dfinity/ic-hs@ebedfe6) make nonexisting canister id in the subnet's ranges ([dfinity/ic-hs#137](https://github.com/dfinity/ic-hs/issues/137)) * [`80875f3a`](dfinity/ic-hs@80875f3) increase error msg length limit ([dfinity/ic-hs#139](https://github.com/dfinity/ic-hs/issues/139))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is not needed for building with nix, and causes more confusion than
is helpful (see
git log -p -- vendor/wasm-spec).