Turn ? into a prefix operator for better readability by rossberg · Pull Request #126 · caffeinelabs/motoko

rossberg · 2019-01-23T14:56:40Z

As discussed...

src/parser.mly

matthewhammer · 2019-01-23T15:13:40Z

test/run-dfinity/chat.as

-charlie.go("charlie", Server);
+let _ = bob.go("bob",Server);
+let _ = alice.go("alice",Server);
+let _ = charlie.go("charlie",Server);


Is this form required for let-binding an async unit?

Yes, we enforce that you cannot silently drop a value by requiring block-level expressions to have type ().

But I'd use ignore instead of "let _ =".

Well, you can name them. The real problem is that you can't yet write an unit returning method that awaits. Await are only legaly within method that return an async, but we could also support the former...

matthewhammer · 2019-01-23T15:25:29Z

The changes in the compiler and in the examples all look great!
Thanks, @rossberg!

rossberg · 2019-01-23T15:34:47Z

You don't want to close a PR. As a reviewer, you want to Approve. ;)

matthewhammer · 2019-01-23T16:38:37Z

Hmm.. I do not see "approve" as an option for me here.
I see "Comment", "Close and comment" and various forms of "Merge".
Is "approval" accomplished by merging, or am I missing something?

rossberg · 2019-01-24T07:38:47Z

@matthewhammer, this being GitHub, nothing in the UI ever is were you'd think it is -- you have to go to the Files Changed tab and click the Review Changes button to get the option to approve. (Reviewers shouldn't normally do the merge, unless the author is an external contributor.)

rossberg · 2019-01-24T07:42:08Z

@nomeata, thanks for fixing!

nomeata · 2019-01-24T08:05:23Z

Also, Github shows the status of the CI tests in a PR; normally you wouldn’t want to merge unless that is green, Matt.

paulyoung · 2019-01-24T17:57:14Z

GitHub can also be configured to disable the merge button unless certain criteria is met (e.g. builds pass, at least n reviews, code coverage, etc) which can help prevent accidentally merging things that aren't ready

rossberg · 2019-01-25T09:29:20Z

@paulyoung, yes, good point, I just configured that (after taking 5 minutes to find the option again).

matthewhammer · 2019-01-28T16:14:43Z

@rossberg @nomeata @paulyoung Thanks for all of the help. It's embarrassing to not understand simple workflows like this in github, and to misdo them. I greatly appreciate your patient explanations, and continual help!

matthewhammer

Looks good to me: The new concrete syntax examples (among the changed tests) each look more clear to me than the prior syntax. Thanks!

## Changelog for candid: Branch: Commits: [dfinity/candid@2abea024...f6f794ff](dfinity/candid@2abea02...f6f794f) * [`f6f794ff`](dfinity/candid@f6f794f) Tests for new subtyping rules ([dfinity/candid⁠#126](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/126))

## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...67029cb8](dfinity/ic-hs@2c9f2ea...67029cb) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs⁠#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs⁠#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs⁠#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs⁠#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs⁠#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs⁠#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs⁠#134](https://github.com/dfinity/ic-hs/issues/134))

## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...52736f33](dfinity/ic-hs@2c9f2ea...52736f3) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs⁠#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs⁠#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs⁠#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs⁠#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs⁠#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs⁠#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs⁠#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs⁠#133](https://github.com/dfinity/ic-hs/issues/133))

## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...ed328b87](dfinity/ic-hs@2c9f2ea...ed328b8) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs⁠#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs⁠#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs⁠#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs⁠#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs⁠#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs⁠#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs⁠#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs⁠#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs⁠#135](https://github.com/dfinity/ic-hs/issues/135))

## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...e29764e9](dfinity/ic-hs@2c9f2ea...e29764e) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs⁠#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs⁠#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs⁠#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs⁠#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs⁠#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs⁠#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs⁠#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs⁠#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs⁠#135](https://github.com/dfinity/ic-hs/issues/135)) * [`e29764e9`](dfinity/ic-hs@e29764e) fix conditions on read_state requests ([dfinity/ic-hs⁠#136](https://github.com/dfinity/ic-hs/issues/136))

## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@2c9f2ea8...ebedfe6e](dfinity/ic-hs@2c9f2ea...ebedfe6) * [`8f47bec4`](dfinity/ic-hs@8f47bec) provisional_create_canister_with_cycles takes an optional specified_id ([dfinity/ic-hs⁠#126](https://github.com/dfinity/ic-hs/issues/126)) * [`af73f215`](dfinity/ic-hs@af73f21) Implement ic0.mint_cycles in ic-hs ([dfinity/ic-hs⁠#127](https://github.com/dfinity/ic-hs/issues/127)) * [`cb9b35d6`](dfinity/ic-hs@cb9b35d) Support requests to a subnet ID ([dfinity/ic-hs⁠#128](https://github.com/dfinity/ic-hs/issues/128)) * [`4cd1c3d3`](dfinity/ic-hs@4cd1c3d) charge canister http_request based on target subnet ([dfinity/ic-hs⁠#130](https://github.com/dfinity/ic-hs/issues/130)) * [`5f07313f`](dfinity/ic-hs@5f07313) replace base64 by ascii endpoint in canister http tests ([dfinity/ic-hs⁠#131](https://github.com/dfinity/ic-hs/issues/131)) * [`9607be0c`](dfinity/ic-hs@9607be0) omit ic-ref binary in ic-ref-test artifact ([dfinity/ic-hs⁠#132](https://github.com/dfinity/ic-hs/issues/132)) * [`67029cb8`](dfinity/ic-hs@67029cb) RUN-509: Enable Canister Timers in pre-upgrade ([dfinity/ic-hs⁠#134](https://github.com/dfinity/ic-hs/issues/134)) * [`52736f33`](dfinity/ic-hs@52736f3) add test for timer in post-upgrade on stopped and stopping canister ([dfinity/ic-hs⁠#133](https://github.com/dfinity/ic-hs/issues/133)) * [`ed328b87`](dfinity/ic-hs@ed328b8) implement canister range checks in ic-ref-test ([dfinity/ic-hs⁠#135](https://github.com/dfinity/ic-hs/issues/135)) * [`e29764e9`](dfinity/ic-hs@e29764e) fix conditions on read_state requests ([dfinity/ic-hs⁠#136](https://github.com/dfinity/ic-hs/issues/136)) * [`ebedfe6e`](dfinity/ic-hs@ebedfe6) make nonexisting canister id in the subnet's ranges ([dfinity/ic-hs⁠#137](https://github.com/dfinity/ic-hs/issues/137))

rossberg added 4 commits January 23, 2019 15:19

Flush trace

7d344c3

Make ? a prefix operator

d1ea9df

Doc

94c10db

Oops

06808df

rossberg requested a review from matthewhammer January 23, 2019 14:56

matthewhammer reviewed Jan 23, 2019

View reviewed changes

src/parser.mly Show resolved Hide resolved

matthewhammer reviewed Jan 23, 2019

View reviewed changes

src/parser.mly Show resolved Hide resolved

matthewhammer reviewed Jan 23, 2019

View reviewed changes

matthewhammer closed this Jan 23, 2019

rossberg reopened this Jan 23, 2019

matthewhammer merged commit 70ee2aa into master Jan 23, 2019

rossberg deleted the prefix-quest branch January 24, 2019 07:40

matthewhammer reviewed Jan 28, 2019

View reviewed changes

Conversation

rossberg commented Jan 23, 2019

Uh oh!

Uh oh!

Uh oh!

matthewhammer Jan 23, 2019

Choose a reason for hiding this comment

Uh oh!

rossberg Jan 23, 2019

Choose a reason for hiding this comment

Uh oh!

crusso Jan 23, 2019

Choose a reason for hiding this comment

Uh oh!

matthewhammer commented Jan 23, 2019

Uh oh!

rossberg commented Jan 23, 2019

Uh oh!

matthewhammer commented Jan 23, 2019

Uh oh!

rossberg commented Jan 24, 2019

Uh oh!

rossberg commented Jan 24, 2019

Uh oh!

nomeata commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulyoung commented Jan 24, 2019

Uh oh!

rossberg commented Jan 25, 2019

Uh oh!

matthewhammer commented Jan 28, 2019

Uh oh!

matthewhammer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nomeata commented Jan 24, 2019 •

edited

Loading