reverseproxy: Caddyfile support for health_method #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Thanks! This is awesome of you to add this too. LGTM -- I'll wait for @francislavoie though.
|
Thanks. Please also update one of the adapt tests in https://github.com/caddyserver/caddy/tree/master/caddytest/integration/caddyfile_adapt (one of the |
OK, I've given it a go :) |
francislavoie
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Caddyfile support for setting the request method used for reverse proxy active health checks.
Follow up to #6453, spurred on by #6453 (comment)
Note: There is no check on which HTTP verb is accepted as apparently some people like to make up their own.