Add option to set which HTTP method to use for active health checks #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mohammed90
reviewed
Jul 11, 2024
mholt
approved these changes
Jul 11, 2024
|
This is missing Caddyfile support. |
Open PR to add support here: #6454 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the option
Methodto theActiveHealthChecksstruct, which optionally sets the HTTP method used for the health check requests.Rational
It would be good to be able to use the
HEADHTTP method to limit transfers on upstreams that respond with a large body, or other methods for upstreams that only respond sensibly on eg.POST.I specifically have a JSON RPC upstream that I would like to test and see if it is working. It has a well defined response body to a
POSTrequest, that lets the active health check determine if the underlying service is actually up and ready to serve requests.