Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: filter wrong order id from self-trade trades #1095

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Mar 9, 2023

No description provided.

@kbearXD kbearXD requested review from c9s and gx578007 March 9, 2023 08:17
@bbgokarma-bot
Copy link

Hi @kbearXD,

This pull request may get 211 BBG.

To receive BBG token, please left your polygon address as an issue comment in this pull request with the following format, e.g.,

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG token will be sent to your wallet.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1095 (ead5486) into main (1ebdd37) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   19.76%   19.76%   -0.01%     
==========================================
  Files         433      433              
  Lines       33581    33584       +3     
==========================================
  Hits         6637     6637              
- Misses      26399    26402       +3     
  Partials      545      545              
Impacted Files Coverage Δ
pkg/exchange/max/exchange.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ebdd37...ead5486. Read the comment docs.

@kbearXD kbearXD merged commit 6a6d7a6 into main Mar 9, 2023
@kbearXD kbearXD deleted the fix/maxapi/query-trades-by-order-id branch March 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants