Merge pull request #1095 from c9s/fix/maxapi/query-trades-by-order-id

kbearXD · web-flow · commit 6a6d7a629314 · 2023-03-09T16:59:33.000+08:00
FIX: filter wrong order id from self-trade trades
diff --git a/pkg/exchange/max/exchange.go b/pkg/exchange/max/exchange.go
@@ -192,7 +192,13 @@ func (e *Exchange) QueryOrderTrades(ctx context.Context, q types.OrderQuery) ([]
 			continue
 		}
 
-		trades = append(trades, localTrades...)
+		// because self-trades will contains ask and bid orders in its struct
+		// we need to make sure the trade's order is what we want
+		for _, localTrade := range localTrades {
+			if localTrade.OrderID == uint64(orderID) {
+				trades = append(trades, localTrade)
+			}
+		}
 	}
 
 	// ensure everything is sorted ascending

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,13 @@ func (e *Exchange) QueryOrderTrades(ctx context.Context, q types.OrderQuery) ([]`
`192`	`192`	`continue`
`193`	`193`	`}`
`194`	`194`
`195`		`- trades = append(trades, localTrades...)`
	`195`	`+ // because self-trades will contains ask and bid orders in its struct`
	`196`	`+ // we need to make sure the trade's order is what we want`
	`197`	`+ for _, localTrade := range localTrades {`
	`198`	`+ if localTrade.OrderID == uint64(orderID) {`
	`199`	`+ trades = append(trades, localTrade)`
	`200`	`+ }`
	`201`	`+ }`
`196`	`202`	`}`
`197`	`203`
`198`	`204`	`// ensure everything is sorted ascending`