cranelift: Remove next_fixed_nonallocatable and with_allocs methods
#8566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `next_fixed_nonallocatable` method doesn't do anything any more and
doesn't return anything so calls to it can just be deleted.
The `with_allocs`, `allocate`, and `to_string_with_alloc` methods are
all trivial at this point, so inline them. The bulk of this change was
performed this way:
git grep -lF '.with_allocs(' | xargs sed -i 's/\.with_allocs([^)]*)/.clone()/g'
In a couple cases, this makes the `AllocationConsumer` unused at these
methods' call sites. Rather than changing function signatures in this
PR, just mark those arguments as deliberately unused.
The number of structures being cloned here is unfortunate, and
unnecessary now that we don't need to mutate any of them. But switching
to borrowing them is a bigger change than I want to include here.
github-actions
bot
added
cranelift
cfallin
approved these changes
May 7, 2024
There was a problem hiding this comment.
LGTM, thanks!
Re: cloning, I agree that taking borrows instead is the next step, but (as I'm sure you've thought through but stating for the record here) the original .with_allocs() also returned a copy so this shouldn't be a regression at least. I'm very much in favor of the incremental approach here :-)
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
May 13, 2024
Part of the ongoing saga of bytecodealliance#8524, bytecodealliance#8566, bytecodealliance#8581, and bytecodealliance#8592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
next_fixed_nonallocatablemethod doesn't do anything any more and doesn't return anything so calls to it can just be deleted.The
with_allocs,allocate, andto_string_with_allocmethods are all trivial at this point, so inline them. The bulk of this change was performed this way:git grep -lF '.with_allocs(' | xargs sed -i 's/\.with_allocs([^)]*)/.clone()/g'In a couple cases, this makes the
AllocationConsumerunused at these methods' call sites. Rather than changing function signatures in this PR, just mark those arguments as deliberately unused.The number of structures being cloned here is unfortunate, and unnecessary now that we don't need to mutate any of them. But switching to borrowing them is a bigger change than I want to include here.