Skip to content

x64: Fix the formatting for andn #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliottt merged 2 commits into from
Feb 15, 2023
Merged

x64: Fix the formatting for andn #5789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78ba0c3
Print AluRmRVex instructions with the destination last
elliottt Feb 15, 2023
934ecd1
Update andn tests
elliottt Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cranelift/codegen/src/isa/x64/inst/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,9 +762,9 @@ impl PrettyPrint for Inst {
format!(
"{} {}, {}, {}",
ljustify2(op.to_string(), String::new()),
dst,
src1,
src2,
src1,
dst,
)
}
Inst::UnaryRmR { src, dst, op, size } => {
Expand Down
5 changes: 2 additions & 3 deletions cranelift/filetests/filetests/isa/x64/band_not_bmi1.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@ block0(v0: i8, v1: i8):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; andn %eax, %esi, %edi
; andn %edi, %esi, %eax
; movq %rbp, %rsp
; popq %rbp
; ret


function %reversed_operands(i8, i8) -> i8 {
block0(v0: i8, v1: i8):
v2 = bnot v0
Expand All @@ -27,7 +26,7 @@ block0(v0: i8, v1: i8):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; andn %eax, %edi, %esi
; andn %esi, %edi, %eax
; movq %rbp, %rsp
; popq %rbp
; ret
Expand Down
2 changes: 1 addition & 1 deletion cranelift/filetests/filetests/wasm/i32-not-x64.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
;; block0:
;; jmp label1
;; block1:
;; andn %eax, %esi, %edi
;; andn %edi, %esi, %eax
;; movq %rbp, %rsp
;; popq %rbp
;; ret