x64: Fix the formatting for andn#5789
Merged
elliottt merged 2 commits intobytecodealliance:mainfrom Feb 15, 2023
Merged
Conversation
github-actions
bot
added
cranelift
jameysharp
approved these changes
Feb 15, 2023
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
Exactly how I thought this would look. Thanks for looking into it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatting for the x64
AluRmRVexinstructions followed intel syntax, while we emit at&t syntax for everything else. This PR fixes the argument order in the pretty-printer, and updates the test outputs.This was identified in #5780 (comment)