Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated generic Linker.DefineFunction() and Function.FromCallback() overloads for efficiently invoking callbacks #163

Merged
merged 18 commits into from
Nov 11, 2022
Merged

Use generated generic Linker.DefineFunction() and Function.FromCallback() overloads for efficiently invoking callbacks #163

merged 18 commits into from
Nov 11, 2022

Commits on Oct 11, 2022

  1. Use a T4 text template to generate overloads of generic Linker.Define… 

    …Function() methods that can efficiently call the specified callback without reflection.
    @kpreisser
    kpreisser committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    419c28d View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Simplify.

    @kpreisser
    kpreisser committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    59750ea View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Follow-Up: Also implement the generic overload generation for Functio… 

    …n.FromCallback().
    @kpreisser
    kpreisser committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    e357e2c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Merge 'main' and resolve conflicts.

    @kpreisser
    kpreisser committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    cf649b6 View commit details
    Browse the repository at this point in the history

  2. Follow-Up: Returning a ValueTuple<> with more than 4 type arguments r… 

    …equires to use the overload taking a Delegate.
    @kpreisser
    kpreisser committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    dbd8945 View commit details
    Browse the repository at this point in the history

  3. Add more tests.

    @kpreisser
    kpreisser committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    2728a4e View commit details
    Browse the repository at this point in the history

  4. Follow-Up: Fall back to using reflection instead of throwing an excep… 

    …tion when the parameter/result type combination cannot be represented with the current generic parameters.
    @kpreisser
    kpreisser committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    78e7eb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Merge remote-tracking branch 'bytecodealliance/main' into generic-lin… 

    …ker-define-function
    @kpreisser
    kpreisser committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    ded2d2a View commit details
    Browse the repository at this point in the history

  2. Add more tests including one for a custom callback delegate.

    @kpreisser
    kpreisser committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    fc72a85 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Directly specify the delegate parameter and return types, so that it'… 

    …s not necessary to use reflection to find the delegate's Invoke() method.
    @kpreisser
    kpreisser committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    28770d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'main' into generic-linker-define-function

    @kpreisser
    kpreisser committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    87f727b View commit details
    Browse the repository at this point in the history

  2. Update for changes in bytecodealliance#172.

    @kpreisser
    kpreisser committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    281154c View commit details
    Browse the repository at this point in the history

  3. PR feedback: Extract duplicated code into a separate .t4 file that ca… 

    …n be included in the .tt files.
    @kpreisser
    kpreisser committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    ea9acf4 View commit details
    Browse the repository at this point in the history

  4. PR feedback: Use a bool value for hasCaller.

    @kpreisser
    kpreisser committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fbe1c7d View commit details
    Browse the repository at this point in the history

  5. PR feedback: Use a local tool manifest file for the dotnet-t4 tool, a… 

    …nd invoke it automatically when building the project.
    @kpreisser
    kpreisser committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e4c29b7 View commit details
    Browse the repository at this point in the history

  6. Follow-Up: Run "dotnet tool restore" to automatically make the tool a… 

    …vailable.
    @kpreisser
    kpreisser committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3766b38 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. We no longer need to specify the -o flag since mono/t4#142 has been f… 

    …ixed in version 2.3.1.
    @kpreisser
    kpreisser committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    1083d77 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge 'main' and fix conflicts.

    @kpreisser
    kpreisser committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    1bb509e View commit details
    Browse the repository at this point in the history