Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.3.0 does not respect output extension #142

Closed
Elufimov opened this issue Oct 5, 2022 · 1 comment
Closed

Version 2.3.0 does not respect output extension #142

Elufimov opened this issue Oct 5, 2022 · 1 comment

Comments

@Elufimov
Copy link

Elufimov commented Oct 5, 2022

We use <#@ output extension=".cfg" #> in tt file for output file extension and in last version 2.3.0 this does not work. All output files now have .txt extension. We just point t4 on directory without addition command line options.

@Elufimov Elufimov changed the title Version 2.3.0 does to respect output extension Version 2.3.0 does not respect output extension Oct 5, 2022
mhutch added a commit that referenced this issue Oct 28, 2022
mhutch added a commit that referenced this issue Oct 28, 2022
mhutch added a commit that referenced this issue Oct 28, 2022
@mhutch
Copy link
Member

mhutch commented Oct 28, 2022

Fix is in version 2.3.1.

@mhutch mhutch closed this as completed Oct 28, 2022
kpreisser added a commit to kpreisser/wasmtime-dotnet that referenced this issue Nov 9, 2022
peterhuene pushed a commit to bytecodealliance/wasmtime-dotnet that referenced this issue Nov 11, 2022
…lback()` overloads for efficiently invoking callbacks (#163)

* Use a T4 text template to generate overloads of generic Linker.DefineFunction() methods that can efficiently call the specified callback without reflection.

* Simplify.

* Follow-Up: Also implement the generic overload generation for Function.FromCallback().

* Follow-Up: Returning a ValueTuple<> with more than 4 type arguments requires to use the overload taking a Delegate.

* Add more tests.

* Follow-Up: Fall back to using reflection instead of throwing an exception when the parameter/result type combination cannot be represented with the current generic parameters.

* Add more tests including one for a custom callback delegate.

* Directly specify the delegate parameter and return types, so that it's not necessary to use reflection to find the delegate's Invoke() method.

* Update for changes in #172.

* PR feedback: Extract duplicated code into a separate .t4 file that can be included in the .tt files.

* PR feedback: Use a bool value for hasCaller.

* PR feedback: Use a local tool manifest file for the dotnet-t4 tool, and invoke it automatically when building the project.

* Follow-Up: Run "dotnet tool restore" to automatically make the tool available.

* We no longer need to specify the -o flag since mono/t4#142 has been fixed in version 2.3.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants