Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIMD double-precision conversion instructions #218

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Add SIMD double-precision conversion instructions #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c6306
Add SIMD double-precision conversion instructions
yurydelendik Feb 2, 2021
9bc54ac
v8 encoding
yurydelendik Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/wasmparser/src/binary_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,6 +1645,11 @@ impl<'a> BinaryReader<'a> {
0x50 => Operator::V128Or,
0x51 => Operator::V128Xor,
0x52 => Operator::V128Bitselect,
0x53 => Operator::F64x2ConvertLowI32x4S,
0x54 => Operator::F64x2ConvertLowI32x4U,
0x55 => Operator::I32x4TruncSatF64x2SZero,
0x56 => Operator::I32x4TruncSatF64x2UZero,
0x57 => Operator::F32x4DemoteF64x2Zero,
0x58 => Operator::V128Load8Lane {
memarg: self.read_memarg()?,
lane: self.read_lane_index(16)?,
Expand Down Expand Up @@ -1684,6 +1689,7 @@ impl<'a> BinaryReader<'a> {
0x64 => Operator::I8x16Bitmask,
0x65 => Operator::I8x16NarrowI16x8S,
0x66 => Operator::I8x16NarrowI16x8U,
0x69 => Operator::F64x2PromoteLowF32x4,
0x6b => Operator::I8x16Shl,
0x6c => Operator::I8x16ShrS,
0x6d => Operator::I8x16ShrU,
Expand Down
6 changes: 6 additions & 0 deletions crates/wasmparser/src/operators_validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,6 +1625,12 @@ impl OperatorValidator {
| Operator::F64x2Abs
| Operator::F64x2Neg
| Operator::F64x2Sqrt
| Operator::F32x4DemoteF64x2Zero
| Operator::F64x2PromoteLowF32x4
| Operator::F64x2ConvertLowI32x4S
| Operator::F64x2ConvertLowI32x4U
| Operator::I32x4TruncSatF64x2SZero
| Operator::I32x4TruncSatF64x2UZero
| Operator::F32x4ConvertI32x4S
| Operator::F32x4ConvertI32x4U => {
self.check_non_deterministic_enabled()?;
Expand Down
6 changes: 6 additions & 0 deletions crates/wasmparser/src/primitives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,4 +1196,10 @@ pub enum Operator<'a> {
I8x16RoundingAverageU,
I16x8RoundingAverageU,
I16x8Q15MulrSatS,
F32x4DemoteF64x2Zero,
F64x2PromoteLowF32x4,
F64x2ConvertLowI32x4S,
F64x2ConvertLowI32x4U,
I32x4TruncSatF64x2SZero,
I32x4TruncSatF64x2UZero,
}
7 changes: 7 additions & 0 deletions crates/wasmprinter/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,6 +1441,13 @@ impl Printer {
I32x4MaxS => self.result.push_str("i32x4.max_s"),
I32x4MaxU => self.result.push_str("i32x4.max_u"),
I32x4DotI16x8S => self.result.push_str("i32x4.dot_i16x8_s"),

F32x4DemoteF64x2Zero => self.result.push_str("f32x4.demote_f64x2_zero"),
F64x2PromoteLowF32x4 => self.result.push_str("f64x2.promote_low_f32x4"),
F64x2ConvertLowI32x4S => self.result.push_str("f64x2.convert_low_i32x4_s"),
F64x2ConvertLowI32x4U => self.result.push_str("f64x2.convert_low_i32x4_u"),
I32x4TruncSatF64x2SZero => self.result.push_str("i32x4.trunc_sat_f64x2_s_zero"),
I32x4TruncSatF64x2UZero => self.result.push_str("i32x4.trunc_sat_f64x2_u_zero"),
}
Ok(())
}
Expand Down
8 changes: 8 additions & 0 deletions crates/wast/src/ast/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,13 @@ instructions! {
V128Or : [0xfd, 0x50] : "v128.or",
V128Xor : [0xfd, 0x51] : "v128.xor",
V128Bitselect : [0xfd, 0x52] : "v128.bitselect",

F64x2ConvertLowI32x4S : [0xfd, 0x53] : "f64x2.convert_low_i32x4_s",
F64x2ConvertLowI32x4U : [0xfd, 0x54] : "f64x2.convert_low_i32x4_u",
I32x4TruncSatF64x2SZero : [0xfd, 0x55] : "i32x4.trunc_sat_f64x2_s_zero",
I32x4TruncSatF64x2UZero : [0xfd, 0x56] : "i32x4.trunc_sat_f64x2_u_zero",
F32x4DemoteF64x2Zero : [0xfd, 0x57] : "f32x4.demote_f64x2_zero",

V128Load8Lane(LoadOrStoreLane<1>) : [0xfd, 0x58] : "v128.load8_lane",
V128Load16Lane(LoadOrStoreLane<2>) : [0xfd, 0x59] : "v128.load16_lane",
V128Load32Lane(LoadOrStoreLane<4>) : [0xfd, 0x5a] : "v128.load32_lane",
Expand All @@ -952,6 +959,7 @@ instructions! {
I8x16Bitmask : [0xfd, 0x64] : "i8x16.bitmask",
I8x16NarrowI16x8S : [0xfd, 0x65] : "i8x16.narrow_i16x8_s",
I8x16NarrowI16x8U : [0xfd, 0x66] : "i8x16.narrow_i16x8_u",
F64x2PromoteLowF32x4 : [0xfd, 0x69] : "f64x2.promote_low_f32x4",
I8x16Shl : [0xfd, 0x6b] : "i8x16.shl",
I8x16ShrS : [0xfd, 0x6c] : "i8x16.shr_s",
I8x16ShrU : [0xfd, 0x6d] : "i8x16.shr_u",
Expand Down
30 changes: 30 additions & 0 deletions tests/local/simd.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,36 @@
i8x16.neg
drop

v128.const i32x4 0 0 0 0
f32x4.demote_f64x2_zero
i8x16.neg
drop

v128.const i32x4 0 0 0 0
f64x2.promote_low_f32x4
i8x16.neg
drop

v128.const i32x4 0 0 0 0
f64x2.convert_low_i32x4_s
i8x16.neg
drop

v128.const i32x4 0 0 0 0
f64x2.convert_low_i32x4_u
i8x16.neg
drop

v128.const i32x4 0 0 0 0
i32x4.trunc_sat_f64x2_s_zero
i8x16.neg
drop

v128.const i32x4 0 0 0 0
i32x4.trunc_sat_f64x2_u_zero
i8x16.neg
drop

)

(memory (;0;) 1)
Expand Down