Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIMD double-precision conversion instructions #218

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Add SIMD double-precision conversion instructions #218

merged 2 commits into from
Feb 4, 2021

Conversation

yurydelendik
Copy link
Contributor

@yurydelendik yurydelendik commented Feb 2, 2021 •
edited
Loading

See WebAssembly/simd#383. This has been accepted into the spec.

  • f32x4.demote_f64x2_zero
  • f64x2.promote_low_f32x4
  • f64x2.convert_low_i32x4_s
  • f64x2.convert_low_i32x4_u
  • i32x4.trunc_sat_f64x2_s_zero
  • i32x4.trunc_sat_f64x2_u_zero

TODO:

  • renumber opcodes

alexcrichton
alexcrichton approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me for when the opcodes are settled

@yurydelendik
Copy link
Contributor Author

Using codes from https://chromium.googlesource.com/v8/v8.git/+/refs/heads/master/src/wasm/wasm-opcodes.h#520

@yurydelendik yurydelendik marked this pull request as ready for review February 4, 2021 00:11
@alexcrichton alexcrichton merged commit 6650f2e into bytecodealliance:main Feb 4, 2021
@yurydelendik yurydelendik mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurydelendik @alexcrichton