Add ARM MacOS to CI #3120
Merged
Add ARM MacOS to CI #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloparco
force-pushed
the
eloparco/macos-arm-ci
branch
from
7827343 to
f5d6f45
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Add ARM MacOS to the CI, to prevent regressions like the one fixed in bytecodealliance#3102 in the future. And add the AOT compilation to the wasi-threads example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ARM MacOS to CI, to prevent regressions like the one fixed in #3102 in the future.
I added the AOT compilation only to the
wasi-threadsexample only because it was the easiest one to apply the change to.I tried it without the change in #3102 (https://github.com/eloparco/wasm-micro-runtime/actions/runs/7755056858/job/21149684750) to make sure the problem would have been detected (and it was indeed).