Fix AOT compilation on MacOS #3102
Conversation
eloparco
force-pushed
the
eloparco/fix-macos-aot
branch
from
3ed7a64 to
0d057e0
Compare
there seems to be a runner with M1. |
|
sure. |
Me neither, it says: |
|
I'll open a PR to add the M1 node when I have time |
Add ARM MacOS to the CI, to prevent regressions like the one fixed in #3102 in the future. And add the AOT compilation to the wasi-threads example.
After bytecodealliance#2995, AOT may stop working properly on arm MacOS: ```bash wasm-micro-runtime/core/iwasm/common/wasm_runtime_common.c, line 1270, WASM module load failed AOT module load failed: mmap memory failed ``` That's because, without `#include <TargetConditionals.h>`, `TARGET_OS_OSX` is undefined, since it's definition is in that header file.
Add ARM MacOS to the CI, to prevent regressions like the one fixed in bytecodealliance#3102 in the future. And add the AOT compilation to the wasi-threads example.
After #2995, AOT stopped working properly on my arm MacOS:
That's because, without
#include <TargetConditionals.h>,TARGET_OS_OSXis undefined (since it's definition is in that header file).I wanted to setup a step in CI for MacOS to avoid things to break again in the future, but in CI AOT seems to work even without (I guess because there we use an Intel MacOS node, not ARM).