Disable FPU in NuttX spec test #2781
Conversation
what problem does this fix? |
| @@ -104,6 +110,11 @@ jobs: | |||
| find nuttx/boards -name defconfig | xargs sed -i '$a\CONFIG_INTERPRETERS_WAMR=y\nCONFIG_INTERPRETERS_WAMR_STACKSIZE=32768\nCONFIG_INTERPRETERS_WAMR_AOT=y\nCONFIG_INTERPRETERS_WAMR_FAST=y\nCONFIG_INTERPRETERS_WAMR_LOG=y\nCONFIG_INTERPRETERS_WAMR_LIBC_BUILTIN=y\nCONFIG_INTERPRETERS_WAMR_REF_TYPES=y\nCONFIG_INTERPRETERS_WAMR_ENABLE_SPEC_TEST=y\nCONFIG_INTERPRETERS_WAMR_SHARED_MEMORY=y\nCONFIG_INTERPRETERS_WAMR_BULK_MEMORY=y\n' | |||
| find nuttx/boards -name defconfig | xargs sed -i '$a\CONFIG_EOL_IS_LF=y\nCONFIG_ARM_SEMIHOSTING_HOSTFS=y\nCONFIG_ARM_SEMIHOSTING_HOSTFS_CACHE_COHERENCE=y\nCONFIG_RISCV_SEMIHOSTING_HOSTFS=y\nCONFIG_FS_HOSTFS=y\nCONFIG_LIBC_FLOATINGPOINT=y\n' | |||
|
|
|||
| - name: Enable additional features for NuttX on RI5C-V | |||
| if: endsWith(matrix.nuttx_board_config, 'rv-virt/configs/nsh') | |||
There was a problem hiding this comment.
if you mean all risc-v configs, isn't it more straightforward to use startsWith('boards/risc-v') ?
NuttX now enabled FPU for rv-vrit by default, but current test script about risc-v is works with FPU disabled so the test can't pass because of the incompatible ABI. I plan to let CI cover more platform, such as aarch64, and existing platform with or without FPU support, but let's do a quick fix first. |
does this basically undo this? apache/nuttx@61460ef |
Yes. |
This will fix spec test on NuttX with #2780 , see: https://github.com/no1wudi/wasm-micro-runtime/actions/runs/6888958439