Refine atomic operation flags in bh_atomic #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
f81f02b to
e0aed13
Compare
no1wudi
changed the title
wenyongh
reviewed
Nov 16, 2023
no1wudi
force-pushed
the
main
branch
4 times, most recently
from
91e942c to
25864e8
Compare
|
i have a concern in the original change which introduced atomic 16. |
yamt
reviewed
Nov 17, 2023
core/shared/utils/bh_atomic.h
Outdated
| * reference to `__atomic_fetch_add_2' | ||
| */ | ||
| #ifndef WASM_UINT16_IS_ATOMIC | ||
| #if !defined(__linux__) && defined(__riscv) |
There was a problem hiding this comment.
what do you mean by !defined(__linux__) here?
do you mean defined(__NuttX__)?
also, why do you override it here, rather than having it in platform-specific headers?
There was a problem hiding this comment.
I guess all non-linux/baremetal platforms has the same issue, not only nuttx, since the usage of the baremetal toolchain have nothing difference with other RTOS platform.
And you can also define the behavior in platfrom-specific setting, explicit settings always have the highest priority.
There was a problem hiding this comment.
I guess the bsd family should be OK as linux, but I don't have a test on it.
wenyongh
pushed a commit
that referenced
this pull request
Nov 18, 2023
Fix spec test failure on NuttX with #2780, see: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/6910450452
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fix the build break in spec test of NuttX.