Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

enable_verifier default disagrees with docs #1247

Closed
iximeow opened this issue Nov 20, 2019 · 0 comments
Closed

enable_verifier default disagrees with docs #1247

iximeow opened this issue Nov 20, 2019 · 0 comments
Labels
bug A bug or panic in the compiler or generated code.

Comments

@iximeow
Copy link
Collaborator

iximeow commented Nov 20, 2019

Currently we state that the verifier is disabled by default, but it is in fact enabled by default. See:

settings.add_bool(
"enable_verifier",
r#"
Run the Cranelift IR verifier at strategic times during compilation.
This makes compilation slower but catches many bugs. The verifier is
disabled by default, except when reading Cranelift IR from a text file.
"#,
true,
);

This default was switched about two years ago, and has been carried forward: 774e8fc

The verifier still catches bugs IME, and it seems like a fine default, but the docs for the flag are wrong!

@iximeow iximeow added the bug A bug or panic in the compiler or generated code. label Nov 20, 2019
bnjbvr added a commit to bnjbvr/cranelift that referenced this issue Dec 3, 2019
bnjbvr added a commit to bnjbvr/cranelift that referenced this issue Dec 4, 2019
@bnjbvr bnjbvr closed this as completed in 6cf60f8 Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A bug or panic in the compiler or generated code.
Projects
None yet
Development

No branches or pull requests

1 participant