Test disable verification in cranelift backend #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
test-disable-ir_verification
branch
from
d364031 to
a96c287
Compare
ethanfrey
reviewed
Mar 26, 2020
|
|
||
| use crate::errors::{CompileErr, Error}; | ||
| use snafu::ResultExt; | ||
|
|
||
| static FAKE_GAS_AVAILABLE: u64 = 1_000_000; | ||
|
|
||
| pub fn compile(code: &[u8]) -> Result<Module, Error> { | ||
| compile_with(code, compiler().as_ref()).context(CompileErr {}) | ||
| let config = CompilerConfig { | ||
| enable_verification: false, // As discussed in https://github.com/CosmWasm/cosmwasm/issues/155 |
There was a problem hiding this comment.
I know this is draft, but it would be interesting to flag this based on test or release, so it is false when we compile for tests and true when we compile for release.
You can do this via
#[cfg(debug_assertions)]
enable_verification: false,
..Default::default(),There was a problem hiding this comment.
I don't know that this cranelift IR (intermediate representation) verifier does, but I think it should not run un release builds.
From bytecodealliance/cranelift#1247:
Run the Cranelift IR verifier at strategic times during compilation.
This makes compilation slower but catches many bugs. [...]
Before wasmerio/wasmer#1218, wasmer disabled it for us in all cases and only enabled it when running Wasmer tests.
I think as long as we don't have a good reason, we should disable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the (unreleased) patch wasmerio/wasmer#1332 for #155
Based on #184