Pull in upstream/master and fix conflicts#2
Merged
bwengals merged 12 commits intobwengals:find_MAP-float32from Aug 16, 2017
Merged
Pull in upstream/master and fix conflicts#2bwengals merged 12 commits intobwengals:find_MAP-float32from
bwengals merged 12 commits intobwengals:find_MAP-float32from
Conversation
Factor is used with multiple inheritance. Those classes should always call super().__init__ to make sure all constructors are properly executed.
missing {}
* Add logp_nojac and logp_sum * Add model name to name of logp variable
bwengals
pushed a commit
that referenced
this pull request
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this brings your PR closer to passing tests (fixes my MLE test). Still may need one more round of fixes after this.