Skip to content

Move selection when typing in search field #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 1 commit into from
Apr 4, 2019
Merged

Move selection when typing in search field #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/devtools/views/Components/TreeContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ function reduceSearchState(store: Store, state: State, action: Action): State {
} = state;

const prevSearchIndex = searchIndex;
const prevSearchText = searchText;
const numPrevSearchResults = searchResults.length;

// Search isn't supported when the owner's tree is active.
Expand Down Expand Up @@ -307,8 +308,8 @@ function reduceSearchState(store: Store, state: State, action: Action): State {
}
}

// Changes in search index should override the selected element.
if (searchIndex !== prevSearchIndex) {
// Changes in search index or typing should override the selected element.
if (searchIndex !== prevSearchIndex || searchText.indexOf(prevSearchText) === 0) {
Copy link
Owner

@bvaughn bvaughn Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yeah this makes sense.

if (searchIndex === null) {
selectedElementIndex = null;
selectedElementID = null;
Expand Down