Move selection when typing in search field #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Apr 4, 2019
| // Changes in search index should override the selected element. | ||
| if (searchIndex !== prevSearchIndex) { | ||
| // Changes in search index or typing should override the selected element. | ||
| if (searchIndex !== prevSearchIndex || searchText.indexOf(prevSearchText) === 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.
I noticed search often selects a random item.
But looking closer, it was because of a partial match:
This changes the algorithm to also change the selection if you continue typing in the search field. I think this feels better. It also matches what Chrome does in text search more closely. (Although not quite — but implementing 1:1 mapping seems like too much complexity right now.)