v6.10.0 Release #502
Merged
v6.10.0 Release #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SignalException to default ignore_classes With #397 we receive SignalException error reports when puma shuts down, which aren't really errors. * Remove exit exception checks in integrations These are now in the default ignore_classes. * Improve IgnoredExceptions: Remove exception rejection from sidekiq integration
|
I'm not sure why codeclimate has only detected this now, it's a pain. I'll raise a ticket to review codeclimate and possibly create a settings file to ensure it's not going to be creating false positives. |
|
Seems ok to review linting issues on a case-by-case basis. The ones which popped for this PR had similar looking code but weren't related to each other, so I marked them as wontfix. |
tobyhs
approved these changes
Dec 5, 2018
| @@ -1062,7 +1071,7 @@ def gloops | |||
| expect(exception["message"]).to eq("'nil' was notified as an exception") | |||
| } | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
How did this trailing whitespace get in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates Version & Changelog for the v6.10.0 release of: #497 #479 #495