Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignalException to default ignore_classes #479

Merged
merged 4 commits into from
Nov 14, 2018

Conversation

tobyhs
Copy link
Contributor

@tobyhs tobyhs commented Aug 1, 2018

Goal

With #397 we receive SignalException error reports when puma shuts down, which aren't really errors.

Changeset

Added

Removed

Changed

  • Changed Interrupt to SignalException in the default Bugsnag::Configuration's ignore_classes

Linked issues

Related to #397 and #477

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

With #397 we receive SignalException error reports when puma shuts down,
which aren't really errors.
Copy link
Contributor

@snmaynard snmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some integrations we do something similar to hide certain exception types. I feel like we should stop doing that as we have moved them into default ignore classes. Places like

raise ex if [Interrupt, SystemExit, SignalException].include? ex.class

These are now in the default ignore_classes.
@Cawllec Cawllec changed the base branch from master to next November 5, 2018 17:03
@Cawllec Cawllec dismissed snmaynard’s stale review November 9, 2018 13:42

Has been addressed

Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but as I've added to it can I get a review from someone else in the @bugsnag/platforms group

@kattrali kattrali merged commit e463ca3 into next Nov 14, 2018
@kattrali kattrali deleted the add_SignalException_to_default_ignore_classes branch November 14, 2018 19:42
@Cawllec Cawllec mentioned this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants