Create structured BugsnagError class #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
v6-structured-error-class
branch
from
b033dc7 to
168f49b
Compare
fractalwrench
force-pushed
the
v6-structured-error-class
branch
from
168f49b to
58f5def
Compare
fractalwrench
force-pushed
the
v6-structured-error-class
branch
from
58f5def to
176033f
Compare
Remove attachCustomStacktrace from public API
CHANGELOG.md
Outdated
| @@ -23,6 +23,12 @@ Bugsnag Notifiers on other platforms. | |||
| * Add `originalError` property to `BugsnagEvent` | |||
| [#541](https://github.com/bugsnag/bugsnag-cocoa/pull/541) | |||
|
|
|||
| * Remove attachCustomStacktrace from public API | |||
There was a problem hiding this comment.
nit: attachCustomStacktrace formatting.
robinmacharg
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Converts
event.errorsfrom anNSDictionaryto a structured class where each field is represented as a property.BugsnagErrorrepresents a single error that caused the event, and contains the error class/message/type/stacktrace.Changeset
BugsnagErrorclass with properties for each field in the specBugsnagEventto use readonlyNSArray<BugsnagError *>BugsnagErrorBSGErrorTypeto represent errors. Note that this requires the rename ofconfiguration.enabledErrorTypestoBSGEnabledErrorTypeto prevent a symbol clasherrorClassanderrorMessagefromBugsnagEventTests
BugsnagErrorpopulates correctly, and that it serializes JSON correctly