Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attachCustomStacktrace from public API #547

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Remove attachCustomStacktrace from public API #547

merged 1 commit into from
Apr 20, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the attachCustomStacktrace method from BugsnagEvent in favour of editing the event.errors property instead.

Changeset

Removed attachCustomStacktrace from public header file for BugsnagEvent.

Tests

Updated existing tests to use attachCustomStacktrace as an internal API instead, by exposing it as a class extension in the test fixture.

@fractalwrench fractalwrench marked this pull request as ready for review April 17, 2020 12:49
robinmacharg
robinmacharg approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit c778d74 into v6-structured-error-class Apr 20, 2020
@fractalwrench fractalwrench deleted the v6-attach-stacktrace branch April 20, 2020 08:54
@gtchance gtchance mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmacharg robinmacharg robinmacharg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @robinmacharg