-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create structured BugsnagThread class #532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
v6-structured-thread
branch
from
April 8, 2020 13:52
8bdc07b
to
062f198
Compare
fractalwrench
force-pushed
the
v6-structured-stacktrace
branch
from
April 8, 2020 15:12
413e92b
to
c50dbaa
Compare
fractalwrench
force-pushed
the
v6-structured-thread
branch
from
April 8, 2020 15:32
062f198
to
c1cce43
Compare
robinmacharg
reviewed
Apr 9, 2020
robinmacharg
reviewed
Apr 9, 2020
robinmacharg
reviewed
Apr 9, 2020
robinmacharg
reviewed
Apr 9, 2020
robinmacharg
reviewed
Apr 9, 2020
robinmacharg
suggested changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a couple of nits and querying the necessity of a parameter, a few comments would help my understanding. Other than that, Looks good!
fractalwrench
force-pushed
the
v6-structured-stacktrace
branch
from
April 9, 2020 10:32
c50dbaa
to
8402c86
Compare
fractalwrench
force-pushed
the
v6-structured-thread
branch
from
April 9, 2020 10:48
c1cce43
to
cbed144
Compare
robinmacharg
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Creates a publicly accessible
BugsnagThread
class which holds fields in properties, rather than anNSDictionary
.This is used as a readonly array property on
BugsnagEvent
, where the user can alter thread information in callbacks. The changeset relies on #528 which has not yet been merged.Changeset
Add properties to
BugsnagThread
which can be edited by the user. Note that these deviate from the spec, specificallythread.name
whose value will always be nil by defaultUpdated
BugsnagEvent
thread generation to occur in constructor rather than in thetoJson
methodUpdated
BugsnagEvent
JSON serialization to useBugsnagThread
internallyTests
Added unit tests to verify that threads can be parsed from a dictionary/serialized to JSON. Added additional coverage to ensure that thread information is enhanced with
isPC
andisLR
. Relied on existing unit test coverage to verify the event JSON remains unchanged.