-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create structured BugsnagStackframe class #528
Conversation
90430b8
to
2cc5cf3
Compare
2cc5cf3
to
a26ae8c
Compare
a26ae8c
to
413e92b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Couple of comments very similar to the event.device
ones, unsurprisingly given the sequence of commits. Also, small Xcode nitpick: it looks like the Event class has moved out of sequence to the top of the Payload group.
413e92b
to
c50dbaa
Compare
Addressed inline comments and resolved the XCode source code organisation nit. I've also rebased against v6 to fix the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
c50dbaa
to
8402c86
Compare
Goal
Creates a publicly accessible
BugsnagStackframe
class which holds fields in properties, rather than anNSDictionary
.A project-visible
BugsnagStacktrace
has been created to sanitise the stacktrace - notably by trimming its length to <200 frames, as per the spec.The
BugsnagStackframe
class will eventually be present on theBugsnagError
andBugsnagThread
classes, which will be implemented in future PRs. For now the JSON serializer has been updated to use the object internally.Changeset
BugsnagStackframe
which can be edited by the user. Note that these deviate from the specBugsnagStacktrace
which limits the number ofBugsnagStackframe
to <200, and encapsulates stacktraces to allow any similar modifications in futureBugsnagEvent
JSON serialization to useBugsnagStacktrace
internallyBSGFormatFrame
to serializers inBugsnagStackframe/BugsnagStacktrace
Tests
Added unit tests to verify that stacktraces can be parsed from a dictionary/serialized to JSON. Relied on existing unit test coverage to verify the event JSON remains unchanged.