feat(spec): Added designated initializer to BugsnagConfiguration #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
reviewed
Jan 22, 2020
kattrali
suggested changes
Jan 23, 2020
12 tasks
kattrali
reviewed
Jan 24, 2020
fractalwrench
approved these changes
Jan 29, 2020
(effectively) removed convenience init, updated ObjC tests, added Swift test, adjusted designated initializer's Swift exposure fix: Updated .gitignore to exclude IDEWorkspaceChecks.plist
Co-Authored-By: Delisa <[email protected]>
Co-Authored-By: Delisa <[email protected]>
Added .md files to project to make updates simpler.
Adding swift has broken the Xcode 10.2 env, fix by creating a dir https://stackoverflow.com/questions/55389080/
robinmacharg
force-pushed
the
add-configuration-designated-initializer
branch
from
ac94f68 to
1d43f5d
Compare
(effectively) removed convenience init, updated ObjC tests, added Swift test, adjusted designated initializer's Swift exposure fix: Updated .gitignore to exclude IDEWorkspaceChecks.plist
Adding swift has broken the Xcode 10.2 env, fix by creating a dir https://stackoverflow.com/questions/55389080/
…e rigorous testing.
…ion-designated-initializer
…:bugsnag/bugsnag-cocoa into add-configuration-designated-initializer
…iguration-designated-initializer # Conflicts: # CHANGELOG.md # Tests/BugsnagEventTests.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The notifier spec. states that an
apiKeymust be provided when initializing aBugsnagConfiguration. To this end removing the default constructor and providing a new apiKey-accepting designated initializer is the solution.Design
An initializer has been added to
BugsnagConfigurationand its designated status indicated with theNS_DESIGNATED_INITIALIZERmacro.init()is required (calls to designated initializers MUST call super) but has been made to fail if called. It was desired to provideapiKeyas an unnamed parameter but theNS_SWIFT_NAMEmacro doesn't appear to offer this functionality.Changeset
A new initializer was added. The default
init()was made to fail.Tests
Unit tests were added to ensure that the new initializer performed as expected. All tests that depended on the default init() have been modified to use the new initializer. A Swift test was added to ensure that the method is exposed correctly.
Review
Outstanding Questions
masterfor fixes,nextforfeatures)