Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a breadcrumb when the library starts #445

Merged
merged 1 commit into from
Jan 24, 2020
Merged

feat: Add a breadcrumb when the library starts #445

merged 1 commit into from
Jan 24, 2020

Conversation

kattrali
Copy link
Contributor

From Breadcrumbs > Behavior > Automatic breadcrumb types:

Bugsnag loaded

  • Bugsnag loaded Breadcrumbs shall be implemented on every platform.
  • When the notifier has been initialized and starts tracking errors a Breadcrumb shall be collected.
  • The Breadcrumb shall have the type set to 'state'.
  • The message shall be set to 'Bugsnag loaded'.

@kattrali kattrali requested a review from robinmacharg January 22, 2020 13:07
@kattrali kattrali force-pushed the kattrali/breadcrumb-start branch from 4fa948c to 66443ab Compare January 22, 2020 18:25
robinmacharg
robinmacharg approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one small query (which I think comes down to personal preference as much as anything) LGTM.

@kattrali kattrali force-pushed the kattrali/breadcrumb-start branch from 66443ab to 1df493a Compare January 23, 2020 15:25
@kattrali kattrali changed the base branch from master to spec-compliance January 24, 2020 09:31
@kattrali kattrali merged commit 412006e into spec-compliance Jan 24, 2020
@kattrali kattrali deleted the kattrali/breadcrumb-start branch January 24, 2020 09:31
robinmacharg pushed a commit that referenced this pull request Jan 29, 2020
@kattrali @robinmacharg
feat: Add a breadcrumb when the library starts (#445)
6bf1ecb
robinmacharg pushed a commit that referenced this pull request Feb 4, 2020
@kattrali @robinmacharg
feat: Add a breadcrumb when the library starts (#445)
1e38919
robinmacharg pushed a commit that referenced this pull request Feb 4, 2020
@kattrali @robinmacharg
feat: Add a breadcrumb when the library starts (#445)
fc99431
robinmacharg added a commit that referenced this pull request Feb 4, 2020
@robinmacharg
feat(spec): Added designated initializer to BugsnagConfiguration (#446)
6c74bfb 
Co-Authored-By: Delisa <[email protected]>

* Added designated initializer to BugsnagConfiguration.  Designated initializer is Swift-throws-friendly, and exposed correctly via NS_SWIFT_NAME.

* Made convenience init() non-functional.

* Updated ObjC tests, added Swift test

* Early-merged some additional bits and pieces that got rolled in during CI fixes.  incl.  Rename-BugsnagCrashReport-to-BugsnagEvent, added .md files to project to make updates simpler. Add a breadcrumb when the library starts (#445)

* Updates to .gitignore to exclude IDEWorkspaceChecks.plist

* CI: Fix build on Xcode 10 for swift tests.  Adding Swift has broken the Xcode 10.2 env, fix by creating a dir (https://stackoverflow.com/questions/55389080/).  Update CI tests to account for mandatory API_KEY.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmacharg robinmacharg robinmacharg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattrali @robinmacharg