-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change font family, fix invalid CSS (fixes #70) #253
Conversation
@niutech Through the linked issue it appears you're using "Windows 10 with devicePixelRatio=1.25". Did you test your patch with any other system, i.e. Linux? |
No, right now I have only Windows 10 machine, I will test it as soon as I get to the Linux computer. |
@niutech |
Yes, I'll post some screenshots when I test it in Linux.
|
Thanks so much for this, for doing the research, finding a fix and submitting the screenshots. I'm happy to merge this. Just one thing, but don't worry if you don't get round to it, could you squash these 2 commits and just create a little commit message giving the context to these changes. |
You can easily squash commits by yourself while merging: https://github.blog/2016-04-01-squash-your-commits/ |
f290601
to
81f41b7
Compare
@tombh Will you merge this PR? |
Sorry for the delay. By asking you to rebase I was hoping you'd be able to better name and describe the commit. Then I just forgot about it. |
CSS values
image-rendering: optimizeSpeed
andoptimize-contrast
are invalid, as are// single-line comments
.Now with
font-family: 'Courier New', monospace
a web page text fits its background image (issue #70).