Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong font-size on Wikipedia articles #70

Closed
niutech opened this issue Jul 9, 2018 · 2 comments
Closed

Wrong font-size on Wikipedia articles #70

niutech opened this issue Jul 9, 2018 · 2 comments
Labels
bug
Projects
Roadmap

Comments

@niutech
Copy link
Contributor

niutech commented Jul 9, 2018

When browsing Wikipedia using Chrome/Firefox on Windows 10 with devicePixelRatio=1.25, the article text has too small left padding (see screenshot below). Setting the font-size: 16.5px; on body fixes this problem.

screenshot
@tombh
Copy link
Member

tombh commented Jul 9, 2018

That's interesting. And thanks for the fix. So I assume I can fix this by detecting devicePixelRatio and doing some maths to set the correct padding. I'm gonna have to look into it.

@tombh tombh added the bug label Jul 9, 2018
@tombh tombh added this to To Do in Roadmap Jul 20, 2018
@niutech niutech mentioned this issue Feb 1, 2019
Merged
@niutech
Copy link
Contributor Author

niutech commented Feb 6, 2019 •
edited
Loading

I think I found the real issue: on Windows 10 font-family: monospace is using Consolas font, which is shorter than Courier New. So the device-ratio-agnostic solution is to use font-family: 'Courier New', monospace instead and remain the 15px font size.

@tombh tombh closed this as completed in f62d7dc Oct 1, 2019
Roadmap automation moved this from To Do to Done Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tombh @niutech