-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reformat ztests with gopkg.in/yaml.v3 #2910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a lint step that runs this?
Lay groundwork for automatic transformations on ztests by reformatting them with gopkg.in/yaml.v3.
After go-yaml/yaml#738 is merged. Without that, a number of multiline literals are converted to double-quoted style for no good reason, making them hard to read. |
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Aug 10, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2910, authored by @nwt, has been merged. reformat ztests with gopkg.in/yaml.v3 Lay groundwork for automatic transformations on ztests by reformatting them with gopkg.in/yaml.v3. Depends on brimdata/super#2909.
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Aug 10, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2910, authored by @nwt, has been merged. reformat ztests with gopkg.in/yaml.v3 Lay groundwork for automatic transformations on ztests by reformatting them with gopkg.in/yaml.v3. Depends on brimdata/super#2909.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Aug 10, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2910, authored by @nwt, has been merged. reformat ztests with gopkg.in/yaml.v3 Lay groundwork for automatic transformations on ztests by reformatting them with gopkg.in/yaml.v3. Depends on brimdata/super#2909.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Aug 10, 2021
…z output" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2911, authored by @nwt, has been merged. remove space before decorator in ZSON -pretty=0/-z output The operative change is in zson//formatter.go. Everything else here just updates tests. Depends on brimdata/super#2910. Closes brimdata/super#2821.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Aug 10, 2021
…z output" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2911, authored by @nwt, has been merged. remove space before decorator in ZSON -pretty=0/-z output The operative change is in zson//formatter.go. Everything else here just updates tests. Depends on brimdata/super#2910. Closes brimdata/super#2821.
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Aug 10, 2021
…z output" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2911, authored by @nwt, has been merged. remove space before decorator in ZSON -pretty=0/-z output The operative change is in zson//formatter.go. Everything else here just updates tests. Depends on brimdata/super#2910. Closes brimdata/super#2821.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lay groundwork for automatic transformations on ztests by reformatting
them with gopkg.in/yaml.v3.
Depends on #2909.