Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat ztests with gopkg.in/yaml.v3 #2910

Merged
merged 1 commit into from
Aug 10, 2021
Merged

reformat ztests with gopkg.in/yaml.v3 #2910

merged 1 commit into from
Aug 10, 2021

Conversation

nwt
Copy link
Member

@nwt nwt commented Aug 6, 2021

Lay groundwork for automatic transformations on ztests by reformatting
them with gopkg.in/yaml.v3.

Depends on #2909.

Copy link
Collaborator

@mattnibs mattnibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a lint step that runs this?

Base automatically changed from prepare-ztests to main August 10, 2021 18:10
Lay groundwork for automatic transformations on ztests by reformatting
them with gopkg.in/yaml.v3.
@nwt nwt force-pushed the reformat-ztests branch from 6cbc14b to 4df65fd Compare August 10, 2021 18:12
@nwt
Copy link
Member Author

nwt commented Aug 10, 2021

Maybe add a lint step that runs this?

After go-yaml/yaml#738 is merged. Without that, a number of multiline literals are converted to double-quoted style for no good reason, making them hard to read.

@nwt nwt merged commit 1924d64 into main Aug 10, 2021
@nwt nwt deleted the reformat-ztests branch August 10, 2021 18:23
brim-bot pushed a commit to brimdata/brimcap that referenced this pull request Aug 10, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2910, authored by @nwt,
has been merged.

reformat ztests with gopkg.in/yaml.v3

Lay groundwork for automatic transformations on ztests by reformatting
them with gopkg.in/yaml.v3.

Depends on brimdata/super#2909.
brim-bot pushed a commit to brimdata/zui that referenced this pull request Aug 10, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2910, authored by @nwt,
has been merged.

reformat ztests with gopkg.in/yaml.v3

Lay groundwork for automatic transformations on ztests by reformatting
them with gopkg.in/yaml.v3.

Depends on brimdata/super#2909.
brim-bot pushed a commit to brimdata/brimcap that referenced this pull request Aug 10, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2910, authored by @nwt,
has been merged.

reformat ztests with gopkg.in/yaml.v3

Lay groundwork for automatic transformations on ztests by reformatting
them with gopkg.in/yaml.v3.

Depends on brimdata/super#2909.
brim-bot pushed a commit to brimdata/brimcap that referenced this pull request Aug 10, 2021
…z output" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2911, authored by @nwt,
has been merged.

remove space before decorator in ZSON -pretty=0/-z output

The operative change is in zson//formatter.go.  Everything else here
just updates tests.

Depends on brimdata/super#2910.

Closes brimdata/super#2821.
brim-bot pushed a commit to brimdata/brimcap that referenced this pull request Aug 10, 2021
…z output" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2911, authored by @nwt,
has been merged.

remove space before decorator in ZSON -pretty=0/-z output

The operative change is in zson//formatter.go.  Everything else here
just updates tests.

Depends on brimdata/super#2910.

Closes brimdata/super#2821.
brim-bot pushed a commit to brimdata/zui that referenced this pull request Aug 10, 2021
…z output" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2911, authored by @nwt,
has been merged.

remove space before decorator in ZSON -pretty=0/-z output

The operative change is in zson//formatter.go.  Everything else here
just updates tests.

Depends on brimdata/super#2910.

Closes brimdata/super#2821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants