Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove decorator space in -z output #2821

Closed
mccanne opened this issue Jun 22, 2021 · 1 comment · Fixed by #2911
Closed

remove decorator space in -z output #2821

mccanne opened this issue Jun 22, 2021 · 1 comment · Fixed by #2911
Assignees
Milestone

Comments

@mccanne
Copy link
Collaborator

mccanne commented Jun 22, 2021

The only space that appears in -z output is between a value and its decorator. We should remove this for consistency (while keeping the space in -Z output). e.g., {a:1(int8)} instead of {a:1 (int8)}.

@philrz philrz added this to the Data MVP0 milestone Jun 23, 2021
@nwt nwt self-assigned this Jun 29, 2021
@nwt nwt closed this as completed in #2911 Aug 10, 2021
brim-bot pushed a commit to brimdata/brimcap that referenced this issue Aug 10, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…z output" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2911, authored by @nwt,
has been merged.

remove space before decorator in ZSON -pretty=0/-z output

The operative change is in zson//formatter.go.  Everything else here
just updates tests.

Depends on brimdata/super#2910.

Closes brimdata/super#2821.
brim-bot pushed a commit to brimdata/brimcap that referenced this issue Aug 10, 2021
…z output" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2911, authored by @nwt,
has been merged.

remove space before decorator in ZSON -pretty=0/-z output

The operative change is in zson//formatter.go.  Everything else here
just updates tests.

Depends on brimdata/super#2910.

Closes brimdata/super#2821.
brim-bot pushed a commit to brimdata/zui that referenced this issue Aug 10, 2021
…z output" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#2911, authored by @nwt,
has been merged.

remove space before decorator in ZSON -pretty=0/-z output

The operative change is in zson//formatter.go.  Everything else here
just updates tests.

Depends on brimdata/super#2910.

Closes brimdata/super#2821.
@philrz
Copy link
Contributor

philrz commented Aug 17, 2021

Verified in Zed commit 1099f2f.

At Zed commit 1924d64 that was right before the changes in the linked PR, this space was present:

$ zq -version
Version: v0.29.0-447-g1924d649

$ echo '{"foo": 1}' | zq -z 'put foo:=int8(foo)' -
{foo:1 (int8)} (=0)

Now on Zed commit 1099f2f, it's gone.

$ zq -version
Version: v0.29.0-460-g1099f2f6

$ echo '{"foo": 1}' | zq -z 'put foo:=int8(foo)' -
{foo:1(int8)}(=0)

As noted above, the space is still present in the -Z output.

$ echo '{"foo": 1}' | zq -Z 'put foo:=int8(foo)' -
{
    foo: 1 (int8)
} (=0)

Thanks @nwt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants