-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jest type instead of jasmine types #24
Comments
Thanks for the report. I have a fix in progress for using Unfortunately, |
@inventer99 Is it not an option to use |
@Robin-Hoodie I see how my reply may have been confusing. Your originally suggested solution for the My comment was in regard to the types packages ( |
Add support single application projects and workspaces with apps and libraries. ## Jest runner Replace the direct reliance on [`jest-preset-angular`](https://github.com/thymikee/jest-preset-angular) and package json scripts in favor of [`angular-builders/jest`](https://github.com/just-jeb/angular-builders/tree/master/packages/jest). This provides the ability to run tests with `ng test` This should address #30 #28 #22 #11 It better positions us to support #1 ## Jest types Update each projects `tsconfig.spec.json` to configure the `jest` types while removing `jasmine` This should address #24 #14 ## Other Non-user facing changes - refactor development scripts from `package.json` to TS file - create 2 sandboxes (single app and workspace with app and lib) - test both sandboxes during CI - add MIT license - add prettier
I've looped this change into a larger PR. Please see if |
Is your feature request related to a problem? Please describe.
As Jest types are built on top of It would probably be a better idea to use Jest types instead of the default Jasmine types Angular comes with. We're already adding
@types/jest
topackage.json
, but it doesn't seem like we're actually using it.Describe the solution you'd like
After adding this schematic with
ng add
, we could, in addition to the current functionality@types/jasmine
frompackage.json
@types/jasminewd2
frompackage.json
types: ["jasmine", "node"]
totypes: ["jest", "node"]
intsconfig.spec.json
The text was updated successfully, but these errors were encountered: