Use jest type instead of jasmine types

[Robin-Hoodie]

Is your feature request related to a problem? Please describe.
As Jest types are built on top of It would probably be a better idea to use Jest types instead of the default Jasmine types Angular comes with. We're already adding @types/jest to package.json, but it doesn't seem like we're actually using it.

Describe the solution you'd like

After adding this schematic with ng add, we could, in addition to the current functionality

• Remove @types/jasmine from package.json
• Remove @types/jasminewd2 from package.json
• Change types: ["jasmine", "node"] to types: ["jest", "node"] in tsconfig.spec.json

[strattonwhisler]

Thanks for the report.

I have a fix in progress for using types: ["jest", "node"] instead of types: ["jasmine", "node"] in tsconfig.spec.json.

Unfortunately, @types/jasmine and @types/jasminewd2 cannot be removed without causing issues with E2E testing since Protractor is configured to use Jasmine. At the moment, Protractor doesn't support Jest (see angular/protractor#3889). Looks like the Protractor team would be open to adding Jest support though (angular/protractor#3889 (comment)). Until then, this schematic will have to keep Jasmine around.

[Robin-Hoodie]

@inventer99 Is it not an option to use types: ["jest", "jasmine", "node"] in that case?

[strattonwhisler]

@Robin-Hoodie I see how my reply may have been confusing.

Your originally suggested solution for the types entry in tsconfig.spec.json is correct. e2e and unit tests use different tsconfig.json files, so the unit tests can utilize types: ['jest', 'node'] while the e2e tests utilize types: ['jasmine', 'jasminewd2', 'node']. We don't need to merge the two.

My comment was in regard to the types packages (node_modules) for Jasmine rather than the compilerOptions.types . Since e2e tests use Jasmine, we need to keep the types/packages around, even though the unit tests no longer use them.

[schuchard]

I've looped this change into a larger PR. Please see if ng add @briebug/[email protected] solves the issue

[HamzaMoiyadi]

Hey,
I just installed version 3.1.0, which has the jest type added in the tsconfig.spec.json correctly, however I am still getting the following issue. Am I doing something wrong here?