Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries generated by cli using ng generate library creates a subproject using Karma intead of Jest #1

Open
frenetic opened this issue Sep 17, 2018 · 6 comments

Comments

@frenetic
Copy link

Reopen from briebug/jest#9.
At first it was a bug report... now I think it is a feature request

Is your feature request related to a problem? Please describe.
After using this schematics to convert my project into a Jest one, I expected all libs I created to also be Jest projects.

Describe the solution you'd like
After running all the steps to convert my project to Jest, when creating a new lib, I expect to, at least, not have a * Karma* configuration file on this lib.
Also, if possible, have the correct jestSetup files.

Describe alternatives you've considered
If it cannot be done automatically, create a script to, at least, remove the karma file.

@schuchard
Copy link
Collaborator

Thanks for moving this issue over. So you're talking about and Angular CLI library not an Nx library correct?

@frenetic
Copy link
Author

Yes. NG CLI only.

@anthonymjones
Copy link
Contributor

I'll look into this.

schuchard added a commit that referenced this issue Sep 2, 2020
Add support single application projects and workspaces with apps and libraries. 

## Jest runner

Replace the direct reliance on [`jest-preset-angular`](https://github.com/thymikee/jest-preset-angular) and package json scripts in favor of [`angular-builders/jest`](https://github.com/just-jeb/angular-builders/tree/master/packages/jest). This provides the ability to run tests with `ng test`

This should address #30 #28 #22 #11 
It better positions us to support #1 

## Jest types

Update each projects `tsconfig.spec.json` to configure the `jest` types while removing `jasmine`

This should address #24 #14

## Other
Non-user facing changes 

- refactor development scripts from `package.json` to TS file
- create 2 sandboxes (single app and workspace with app and lib)
- test both sandboxes during CI
- add MIT license
- add prettier
@ezebc182
Copy link

Is this resolved?

@schuchard
Copy link
Collaborator

This feature has not been built. Generating code with the CLI will still use the defaults. However, this schematic is in a better position to offer this functionality in the future.

@Lonli-Lokli
Copy link

Is there any options except for the Nx?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants