Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[solr,solr6] Add Solr 6 binding #849

Merged
merged 1 commit into from
Oct 20, 2016
Merged

[solr,solr6] Add Solr 6 binding #849

merged 1 commit into from
Oct 20, 2016

Conversation

risdenk
Copy link
Collaborator

@risdenk risdenk commented Sep 27, 2016

Closes #715

@risdenk risdenk force-pushed the ycsb-715 branch 3 times, most recently from 8c50ee1 to a3e3feb Compare September 27, 2016 03:03
@risdenk risdenk mentioned this pull request Sep 27, 2016
Closed
@risdenk
Copy link
Collaborator Author

risdenk commented Sep 27, 2016

@busbey can you review? This would help move forward JDK 9 support (#705 and #712)

@risdenk risdenk added the db-new label Sep 27, 2016
@risdenk risdenk self-assigned this Sep 27, 2016
@risdenk risdenk changed the title [Solr] Add Solr 6 binding [solr,solr6] Add Solr 6 binding Sep 30, 2016
@risdenk risdenk closed this Sep 30, 2016
@risdenk risdenk reopened this Sep 30, 2016
@risdenk
Copy link
Collaborator Author

risdenk commented Oct 3, 2016

bump?

2 similar comments
@risdenk
Copy link
Collaborator Author

risdenk commented Oct 11, 2016

bump?

@risdenk
Copy link
Collaborator Author

risdenk commented Oct 19, 2016

bump?

@busbey
Copy link
Collaborator

busbey commented Oct 20, 2016

jdk8 was my big question. it looks like compilation with jdk7 is fine, but running (including tests) requires jdk8. Do I have that right?

busbey
busbey requested changes Oct 20, 2016
View reviewed changes
Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to have the bin/bindings.properties file updated too.

@risdenk
Copy link
Collaborator Author

risdenk commented Oct 20, 2016

It should be ok compiling with jdk 7. I haven't tested this locally but it seems to compile in travis with jdk 7. As long as we don't use jdk 8+ things (lambdas,etc) in the client then I think it should be ok. Running (including tests) requires JDK8.

@risdenk
Copy link
Collaborator Author

risdenk commented Oct 20, 2016

@busbey good catch. I updated the PR with bin/bindings.properties updated.

@risdenk
Copy link
Collaborator Author

risdenk commented Oct 20, 2016

Just checked and YCSB with Solr 6 compiles locally with JDK 7.

busbey
busbey approved these changes Oct 20, 2016
View reviewed changes
Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@risdenk risdenk merged commit 43d5633 into brianfrankcooper:master Oct 20, 2016
@risdenk risdenk deleted the ycsb-715 branch October 20, 2016 18:36
@risdenk risdenk mentioned this pull request Nov 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busbey busbey busbey approved these changes

Assignees

@risdenk risdenk

Labels
db-new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risdenk @busbey