Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 9, 10, and 11 support for YCSB #705

Closed
risdenk opened this issue Apr 13, 2016 · 15 comments · Fixed by #712
Closed

JDK 9, 10, and 11 support for YCSB #705

risdenk opened this issue Apr 13, 2016 · 15 comments · Fixed by #712

Comments

@risdenk
Copy link
Collaborator

risdenk commented Apr 13, 2016

Since JDK 9 is in early access, it would be good to start testing with it and see what changes may be required to support it.

@risdenk
Copy link
Collaborator Author

risdenk commented Apr 13, 2016

There is an early report in #704 where the build fails.

busbey added a commit to busbey/YCSB that referenced this issue Apr 16, 2016
* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 test crashes with unknown class version, so skip tests
* core jar-with-deps fails, so keep them broken out

fixes brianfrankcooper#705
busbey added a commit to busbey/YCSB that referenced this issue Apr 16, 2016
* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 test crashes with unknown class version, so skip tests
* core jar-with-deps fails, so keep them broken out
* add jdk9 to travis

fixes brianfrankcooper#705
busbey added a commit to busbey/YCSB that referenced this issue Apr 16, 2016
* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 test crashes with unknown class version, so skip tests
* core jar-with-deps fails, so keep them broken out
* add jdk9 to travis

fixes brianfrankcooper#704, fixes brianfrankcooper#705
busbey added a commit to busbey/YCSB that referenced this issue Apr 16, 2016
* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 test crashes with unknown class version, so skip tests
* core jar-with-deps fails, so keep them broken out
* add jdk9 to travis

fixes brianfrankcooper#704, fixes brianfrankcooper#705
busbey added a commit to busbey/YCSB that referenced this issue Apr 17, 2016
* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 test crashes with unknown class version, so skip tests
* core jar-with-deps fails, so keep them broken out

fixes brianfrankcooper#704, fixes brianfrankcooper#705
busbey added a commit to busbey/YCSB that referenced this issue Apr 30, 2016
…xes for jdk9

* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 and asynchbase test crashes with unknown class version, so skip tests
* orientdb tests fail, so skip
* core jar-with-deps fails, so keep them broken out

fixes brianfrankcooper#704, fixes brianfrankcooper#705
busbey added a commit that referenced this issue Sep 30, 2016
…xes for jdk9 (#712)

* in couchbase2 work around ReactiveX/RxJava#3824
* accumulo test hangs, so skip tests
* hbase10 and asynchbase test crashes with unknown class version, so skip tests
* orientdb tests fail, so skip
* core jar-with-deps fails, so keep them broken out

fixes #704, fixes #705
@risdenk risdenk reopened this Sep 30, 2016
@busbey
Copy link
Collaborator

busbey commented Sep 30, 2016

:shakes_fist: No tests after rebase!!! arg. taking a look.

@risdenk
Copy link
Collaborator Author

risdenk commented Sep 30, 2016

The fixes from PR #712 worked need to extend for a few other bindings. Just ran on latest 9-ea 138 and got the following:

Solr 5.x - need to exclude from jdk 9
JDBC - Unable to get class information for SQLException from checkstyle

[INFO] --- maven-checkstyle-plugin:2.15:check (validate) @ jdbc-binding ---
[INFO] There are 8 errors reported by Checkstyle 6.1.1 with checkstyle.xml ruleset.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBCli.java[42:75] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBClient.java[142:47] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBClient.java[257:14] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBClient.java[268:14] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBClient.java[279:14] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBClient.java[290:14] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBClient.java[301:14] (coding) RedundantThrows: Unable to get class information for SQLException.
[ERROR] src/main/java/com/yahoo/ycsb/db/JdbcDBCreateTable.java[43:78] (coding) RedundantThrows: Unable to get class information for SQLException.

@risdenk
Copy link
Collaborator Author

risdenk commented Sep 30, 2016

@busbey I'll have a PR in a minute to fix the above two issues.

@busbey
Copy link
Collaborator

busbey commented Sep 30, 2016

sweet. I just verified it was a flakey build and not that #712 broke things.

@risdenk
Copy link
Collaborator Author

risdenk commented Jan 31, 2017

Looks like there is an issue with the rest binding. The other bindings look good. I ran mvn clean package with the following environment:

# java -version
java version "9-ea"
Java(TM) SE Runtime Environment (build 9-ea+149)
Java HotSpot(TM) 64-Bit Server VM (build 9-ea+149, mixed mode)

# mvn --version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 9-ea, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"

@risdenk
Copy link
Collaborator Author

risdenk commented Jan 31, 2017

I opened #914 to track fixing the rest binding.

@risdenk
Copy link
Collaborator Author

risdenk commented Apr 14, 2017

An update here, I just tested master and got no failures with the following:

#java -version
java version "9-ea"
Java(TM) SE Runtime Environment (build 9-ea+163)
Java HotSpot(TM) 64-Bit Server VM (build 9-ea+163, mixed mode)

#mvn --version
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T15:39:06-04:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 9-ea, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.4", arch: "x86_64", family: "mac"

#mvn clean package
...
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:06 min
[INFO] Finished at: 2017-04-14T10:02:03-04:00
...

@risdenk
Copy link
Collaborator Author

risdenk commented Sep 10, 2017

Manually tested on 9/10/17 at commit 0350c37:

# java -version
java version "9"
Java(TM) SE Runtime Environment (build 9+181)
Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)

# mvn --version
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T14:39:06-05:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 9, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"

# mvn clean package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:20 min
[INFO] Finished at: 2017-09-10T16:14:57-05:00
[INFO] Final Memory: 83M/278M
[INFO] ------------------------------------------------------------------------

@risdenk
Copy link
Collaborator Author

risdenk commented Sep 10, 2017

Travis now supports oraclejdk9 as an option for JDKs.

https://docs.travis-ci.com/user/languages/java/#Overview

@busbey
Copy link
Collaborator

busbey commented Sep 10, 2017

Let's add it to the Travis matrix and then start working through which jdk-specific test activations work on jdk9?

@risdenk
Copy link
Collaborator Author

risdenk commented Sep 13, 2017

Yea agreed started down this path just haven't put up the PR yet. Will do so this week.

This was referenced Sep 22, 2017
@busbey
Copy link
Collaborator

busbey commented Jul 7, 2018

Maybe obsoleted by the move to LTS versions in Java? Should we just focus on JDK11?

@risdenk
Copy link
Collaborator Author

risdenk commented Jul 13, 2018

@busbey yes focusing on LTS versions of Java might be the best course of action. I just put up PR #1186 to try to add JDK 10 and 11 to test on Travis. The same bindings that failed with JDK 9 failed with JDK 10 and 11.

@risdenk risdenk changed the title JDK 9 support for YCSB JDK 9, 10, and 11 support for YCSB Jul 13, 2018
@risdenk
Copy link
Collaborator Author

risdenk commented Jul 15, 2018

With PR #1186 closed, we can probably close this issue. We are now testing against each JDK 8-11.

@risdenk risdenk closed this as completed Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants