Fix a couple clippy lints, run cargo format #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
I've checked it here: rillrate-fossil/rillrate@f9d98dc#diff-20022b08cfe7a90ed8704b3ec3c6491a506c9c4d7436503be2b7434613b78145
It works 👍
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important one for me is the first fix, for
if_then_panic, as it is in a macro, so the lint leaks into dependent crates as well.See: https://github.com/ruffle-rs/ruffle/pull/5400/checks?check_run_id=3761100603 (EDIT: This link has expired since, sorry...)
The rest are just extra little fixes, while I was here...
I also had one for
transmute_float_to_int, but that should be addressed by #63, so I removed it from here.