Replace unsafe with to_bits()
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy also warns about this, suggesting a similar fix. |
While `to_bits()`[1] is implemented as `unsafe { mem::transmute(self) }`
it seems nicer to rely on the standard library to hide the unsafe
implementation. Some people audit the libraries they use and may get
nervous when they see `unsafe`.
[1] https://doc.rust-lang.org/std/primitive.f32.html#method.to_bits
|
Rebased against |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
to_bits()is implemented asunsafe { mem::transmute(self) }it seems nicer to rely on the standard library to hide the unsafe implementation. Some people audit the libraries they use and may get nervous when they seeunsafe.