Skip to content

#233 — pass-2 residual deltas: ct-key color-mix (AA), ct-test gap, bubble radius, Model YAML label #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmbays merged 2 commits into from
Jun 11, 2026
Merged

#233 — pass-2 residual deltas: ct-key color-mix (AA), ct-test gap, bubble radius, Model YAML label #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d05e8e4
fix(adapters): pass-2 residual deltas — ct-key color-mix (AA), ct-tes…
github-actions[bot] Jun 11, 2026
ad78fc9
test: guard the badge-bubble lookup in the D6 radius pin (review)
github-actions[bot] Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions examples/diff-showcase-report.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 22 additions & 6 deletions examples/jaffle-shop-report.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 22 additions & 6 deletions examples/playground-report.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/cli/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ pub struct ReportArgs {
/// `original_file_path` entries.
///
/// When supplied, cute-dbt reads each in-scope `unit_test`'s source
/// YAML and surfaces an "Authoring YAML" drawer in the report
/// (cute-dbt#69). When absent, cute-dbt attempts to derive the
/// YAML and surfaces a "Model YAML" drawer in the report
/// (cute-dbt#69; label per the pass-2 spec, cute-dbt#233). When
/// absent, cute-dbt attempts to derive the
/// project root from `--manifest` (by stripping a trailing
/// `target/manifest.json`) before silently skipping the YAML
/// extraction.
Expand Down
10 changes: 7 additions & 3 deletions templates/interaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,10 @@
// authored YAML exactly as cute-dbt#69 did.
var hasDiff = t.yaml_diff && t.yaml_diff.lines && t.yaml_diff.lines.length;
var $yamlDet = $("<details>").addClass("authoring-yaml").attr("open", "open");
$yamlDet.append($("<summary>").text(hasDiff ? "Authoring YAML — diff" : "Authoring YAML"));
// cute-dbt#233 (audit D7) — pass-2 labels the drawer "Model YAML"
// with no diff-variant suffix; the Diff/File toggle in the code
// header carries the diff affordance.
$yamlDet.append($("<summary>").text("Model YAML"));
var $yamlWrap = $("<div>").addClass("sql-block-wrap fixture-sql-block-wrap");
// cute-dbt#178 — GitHub-style code-card header: the file path sits left
// of the Diff/File toggle. `defined_in` is the test's authoring-YAML
Expand Down Expand Up @@ -3046,13 +3049,14 @@
}

// The external-fixture affordance: never a silently-empty grid. Names the
// file and points the reader at the Authoring YAML drawer (the #96 view),
// file and points the reader at the Model YAML drawer (the #96 view),
// which surfaces the authored block including the `fixture:` line.
// (Pointer copy follows the cute-dbt#233 D7 drawer rename.)
function buildExternalFixtureAffordance(name) {
var $box = $("<div>").addClass("given-empty external-fixture-note");
$box.append(document.createTextNode("data in external fixture file: "));
$box.append($("<code>").addClass("td-defined-in").text(String(name)));
$box.append(document.createTextNode(" — see the Authoring YAML drawer above for this test's block."));
$box.append(document.createTextNode(" — see the Model YAML drawer above for this test's block."));
return $box;
}

Expand Down
18 changes: 15 additions & 3 deletions templates/report.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ g.dag-node:focus-visible { outline: 2px dashed var(--accent); outline-offset: 3p
.mode-badge.has-mode-tip, .this-badge.has-mode-tip { position: relative; cursor: help; }
.mode-badge.has-mode-tip:focus-visible, .this-badge.has-mode-tip:focus-visible { outline: 2px solid var(--accent); outline-offset: 1px; }
.mode-badge.has-mode-tip .expect-tooltip-bubble,
.this-badge.has-mode-tip .expect-tooltip-bubble { left: 0; transform: none; z-index: 60; box-shadow: 0 6px 22px rgba(0,0,0,0.3); }
.this-badge.has-mode-tip .expect-tooltip-bubble { left: 0; transform: none; z-index: 60; box-shadow: 0 6px 22px rgba(0,0,0,0.3); border-radius: var(--radius-sm); /* cute-dbt#233 (audit D6) — pass-2 rounds the badge-borne bubble at --radius-sm; the shared .expect-tooltip-bubble keeps --radius-pan */ }
.mode-badge.has-mode-tip:hover .expect-tooltip-bubble,
.mode-badge.has-mode-tip:focus .expect-tooltip-bubble,
.mode-badge.has-mode-tip:focus-visible .expect-tooltip-bubble,
Expand Down Expand Up @@ -1286,8 +1286,20 @@ th.has-col-meta:focus-visible { outline: 2px solid var(--accent); outline-offset
.col-tooltip .ct-desc { font-size: 1.12em; line-height: 1.5; opacity: 0.97; }
.col-tooltip .ct-tests-label { margin-top: 0.6rem; font-size: 0.82em; text-transform: uppercase; letter-spacing: 0.07em; opacity: 0.6; }
.col-tooltip .ct-tests { display: flex; flex-direction: column; gap: 0.4rem; margin-top: 0.3rem; }
.col-tooltip .ct-test { display: flex; flex-wrap: wrap; align-items: baseline; gap: 0.25rem 0.45rem; }
.col-tooltip .ct-key { font-family: var(--font-mono); font-weight: 700; color: var(--accent); }
.col-tooltip .ct-test { display: flex; flex-wrap: wrap; align-items: baseline; gap: 0.25rem 0.7rem; }
/* cute-dbt#233 (audit D4) — the pass-2 readable-on-dark accent: raw
var(--accent) lands ≈3:1 against the always-dark tooltip fill on the
4 light themes (AA fail); the oklab mix toward white clears 4.5:1 on
all 8 themes (headless-pinned). */
.col-tooltip .ct-key { font-family: var(--font-mono); font-weight: 700; color: color-mix(in oklab, var(--accent) 60%, white); }
Comment thread
cmbays marked this conversation as resolved.
/* cute-dbt#233 — Latte ct-key AA: the spec's own 60% mix lands 3.37:1 on
latte's tooltip fill (#4c4f69 — the lightest of the 8; the spec tokens
carry the same value, so this is empirically the spec's gap, not ours).
The #198/#206/#227 pattern: a scoped stand-in only — the mix shifts
toward white for latte alone (≈5:1 measured); the verbatim latte theme
block and the other 7 themes' spec-literal mix stay pinned. Covers the
model tip too (it rides the .col-tooltip shell). */
:root[data-theme="latte"] .col-tooltip .ct-key { color: color-mix(in oklab, var(--accent) 35%, white); }
Comment thread
cmbays marked this conversation as resolved.
.col-tooltip .ct-vals { display: inline-flex; flex-wrap: wrap; gap: 0.25rem; }
.col-tooltip .ct-val { background: rgba(255,255,255,0.14); border-radius: 4px; padding: 0.05rem 0.42rem; font-family: var(--font-mono); font-size: 0.9em; white-space: nowrap; }
/* (cute-dbt#202 — the .ct-detail run is retired: detail strings now split
Expand Down
Loading
Loading