Repository navigation
#233 — pass-2 residual deltas: ct-key color-mix (AA), ct-test gap, bubble radius, Model YAML label - #237
Conversation
…t gap, bubble radius, Model YAML label (#233) - D4: .col-tooltip .ct-key -> color-mix(in oklab, var(--accent) 60%, white) per pass-2 base.css; latte gets a scoped 35% stand-in (the spec's own 60% mix lands 3.37:1 on latte's #4c4f69 tooltip fill — the #198/#206/#227 pattern). New 8-theme headless AA guard measures the key against the tooltip bubble's OWN fill (the effective backdrop), never --bg/--surface. - D5: .col-tooltip .ct-test gap 0.25rem 0.45rem -> 0.25rem 0.7rem - D6: badge-borne bubble border-radius --radius-pan -> --radius-sm - D7: drawer summary 'Authoring YAML(— diff)' -> 'Model YAML' (no diff suffix — the Diff/File toggle carries it); the external-fixture pointer copy follows the rename; --help text updated. - Goldens regenerated (jaffle-shop, playground, diff-showcase; explore unchanged); chrome snapshot rebaselined; every hunk maps to the four deltas. Closes #233 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 21 minutes and 50 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 5 individual chapters for you:
Chapters generated by Stage for commit ad78fc9 on Jun 11, 2026 6:36pm UTC. |
📄 Rendered report previewAll golden examples regenerated cleanly. 🟡 Golden examplesCommitted to
🐶 Live dogfood previewThis PR doesn't touch ▶ Open ↗ opens the report in your browser in one click — The Pages preview may take ~1 min to update after this comment Alternative: GitHub CLI# gh CLI >= 2.63 extracts into ./report-preview-playground/.
gh run download 27369143755 -R breezy-bays-labs/cute-dbt -n report-preview-playground
open report-preview-playground/playground-report.htmlPosted by |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the 'Authoring YAML' drawer label to 'Model YAML' and applies design-conformance updates for pass-2 specifications, including WCAG AA contrast adjustments using color-mix and border-radius refinements. It also adds comprehensive headless integration tests to verify these visual changes across all themes. The review feedback suggests adding fallback color declarations for older browser compatibility where color-mix is used, and implementing a defensive check in the test's JavaScript evaluation to prevent cryptic type errors if the tooltip bubble is not found.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
A missing '.expect-tooltip-bubble' now surfaces as got == "" with an explicit precondition assert naming the selector, instead of a cryptic in-page TypeError from getComputedStyle(null) (gemini review on #237). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 participant
Summary
Closes the four residual deltas from the 2026-06-11 design-conformance audit where the implementation kept stale pass-1 values that pass-2 revised. Spec citations are to the canonical pass-2 handoff (
design-return-2/claude-code-handoff/engine/)..col-tooltip .ct-key:var(--accent)→color-mix(in oklab, var(--accent) 60%, white).col-tooltip .ct-testgap0.25rem 0.45rem→0.25rem 0.7rem.mode-badge/.this-badge.has-mode-tip .expect-tooltip-bubble) gainsborder-radius: var(--radius-sm)(was inheriting--radius-pan)"Authoring YAML(— diff)"→"Model YAML", no diff-variant suffix — the Diff/File toggle in the code header carries the diff affordanceD4 RED → GREEN (the new headless AA guard)
New guard
col_tooltip_ct_key_meets_aa_contrast_on_every_themeextends the #206/#227 AA family. Methodology per the #206/#227 lesson: contrast is computed from resolved computed styles against the element's effective backdrop — for tooltip text that is the tooltip bubble's own opaque--tooltip-bgfill, never--bg/--surface; the sweep pins this by asserting the ancestor backdrop walk lands exactly on the bubble's own resolved fill. Thecolor-mixfg computes to a non-rgb()serialization, so the sweep normalizes any CSS color through a 1x1 canvas.RED (unfixed tree, raw accent on the tooltip fill):
GREEN (after the fix):
D5/D6/D7 each got a cheap pin: computed row/column-gap in the same guard (RED 4.5px → GREEN 7px), a new
badge_tip_bubble_rounds_at_small_radiustest comparing against in-page--radius-sm/--radius-panreference resolutions (RED at pan → GREEN at sm), and the existing yaml-diff drawer summary pin updated to"Model YAML"(RED on the old label → GREEN).Deviations from the spec literal (deliberate, flagged)
--tooltip-bgis#4c4f69, the lightest of the 8, and the spec tokens (tokens.css:284) carry the same value, so this is empirically the spec's gap. Per the issue's acceptance criterion (≥4.5:1 on ALL 8 themes, verified empirically) and the established feature: design-2 integration PR-1 — chassis delta (3 new AA-pinned themes, diffstyle retirement, DAG final-stroke AA fix) #198/polish: Solarized tier-high chip contrast 3.41 fails AA on shipped main #206/polish: latte suppress-chip 4.37 sub-AA + suppressed-row opacity vs AA (design decision) #227 pattern, a latte-scoped override shifts the mix toward white (35%accent → 4.95:1 measured); the other 7 themes keep the spec-literal 60% mix and the verbatim latte theme block stays pinned.--project-root--helptext naming the drawer was updated likewise.Discovered while measuring (NOT addressed here, candidate follow-up):
.ov-tooltip .ov-keyuses a 50% mix, which by the same math sits ≈4.0:1 on latte's tooltip fill — same shape of fix if wanted.Gates (run directly — not via lefthook)
cargo fmt --check— cleancargo clippy --all-targets --locked -- -D warnings— exit 0cargo nextest run— 1228 passedcargo test --test bdd— 160 scenarios / 1032 steps passedcargo test --test headless_toggle -- --ignored— 55 passedcargo test --test headless_zero_egress -- --ignored— 10 passedRUSTDOCFLAGS="-D warnings" cargo doc --no-deps --locked— exit 0cargo deny check— exit 0Goldens
Regenerated exactly as CI's
example-report-checkmatrix does (jaffle-shop, playground, diff-showcase, explore). The three report goldens changed; the explore pair is byte-identical (it doesn't embed report.css/interaction.js). Audited withgit diff --text -U0 -- examples/: every hunk is one of the four deltas (D6 radius on the badge-bubble rule, D5 gap value, D4 color-mix + latte override + comments, D7 label + pointer copy). The chrome insta snapshot was rebaselined for the same template content.Scope guards honored: no
.f-construct(issue #231's lane), no.model-tooltiprule edits (the latte override rides the shared.col-tooltipshell), heuristics ledger untouched, #146/#161 tooltip contract intact (pure-CSS hover/focus reveal unchanged).Closes #233
🤖 Generated with Claude Code