Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New UI for receive payment flows #167

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

New UI for receive payment flows #167

wants to merge 38 commits into from
+1,871 −1,757

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Sep 9, 2024 •
edited
Loading

This PR unifies receive payment flows under the same page.

Changelist:

  • Unify receive payment methods under same UI d8194ec
    • All receive payment pages are moved under receive_payment dir and ReceivePaymentPage, which takes a pageIndex and displays the selected payment methods page. Renamed files to reflect these changes.
    • UI's are made consistent across all payment pages where possible.
      • All pages now use the same AddressWidget to display payment information.
      • They use similar fee information widgets etc.
    • Dialogs on payment flows are removed or integrated to a fulll page UI as part of their respective flow.
  • Open the bottom sheet menu item via ReceivePaymentPage 3e586b7
  • Remove payment method selector 69a9505

Layout & Theme issues:

  • Do not override ExpiryAndFeeMessage colors on light theme edcc375
  • Move padding to ReceivePayment page 241068a
  • Fix share & copy icon colors 077ded2
  • Fix loader alignment on receive pages 8dc0e40
  • Fix header displacement after QR code loads fc40ccb

Misc:

  • Added Breez icon to QR image
  • Replace hardcoded messages from Breez-Translations d7e6b25
  • Add helper methods for readability d46d4da
    • These will be extracted into their own widgets

TODO:

  • Track payments and close the payment information to display bubble animation on home page when the payment is received 35db836

@erdemyerebasmaz erdemyerebasmaz force-pushed the receive_payment_new_ui branch 3 times, most recently from 6a9135b to 4802ff2 Compare September 9, 2024 11:44
@erdemyerebasmaz erdemyerebasmaz linked an issue Sep 9, 2024 that may be closed by this pull request
Do not display "Receive up to" label on receive pages #141
Open
@erdemyerebasmaz erdemyerebasmaz force-pushed the receive_payment_new_ui branch 7 times, most recently from c5052bc to dcb9253 Compare September 10, 2024 15:36
@erdemyerebasmaz erdemyerebasmaz marked this pull request as ready for review September 11, 2024 10:51
@erdemyerebasmaz erdemyerebasmaz force-pushed the receive_payment_new_ui branch 5 times, most recently from 58afa9f to 818e8c4 Compare September 16, 2024 13:46
This was linked to issues Sep 16, 2024
LNURL - Withdraw screen bug #160
Open
Share and copy buttons missing #172
Closed
Wrong UI on description #174
Closed
@erdemyerebasmaz erdemyerebasmaz removed a link to an issue Sep 17, 2024
LNURL - Withdraw screen bug #160
Open
@erdemyerebasmaz erdemyerebasmaz linked an issue Sep 17, 2024 that may be closed by this pull request
LNURL - Withdraw screen bug #160
Open
@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Sep 17, 2024 •
edited
Loading

@dangeross New changes since last review:

Payment tracking & successful payment animation:

  • Track payments and pop to home page to display bubble animation on receiving payment
  • Only track incoming payments
  • Fade out the bubble animation and pop the SuccessfulPaymentRoute
  • Display payment received message upon receiving a payment
  • Added comments for flip transition animation
  • Removed didUpdateWidget to avoid displaying FlipTransition twice
  • Make time comparison more accurate for FlipTransition

DestinationWidget:

  • Refactored AddressWidget
  • Add padding to payment limits message box loader
  • Renamed and moved address widget folders

LNURL payment:

  • Display errors for LNURL payments that fall below payment limits
  • Fix the minimum value pasted on clicking limits label on LNURL payment page
  • Use domain from LnUrlPayRequestData on it's title

LNURL Withdraw:

  • Support LNURL Withdraw with new UI
  • Created a dedicated LnUrl Withdraw page
  • Display errors for URLs recognized through QR scanner
  • Fix amount auto focus on LnUrlWithdrawPage
  • Remove LnUrlWithdraw logic from ReceiveLightningPaymentPage

@erdemyerebasmaz
Add helper methods for readability
a7dd569 
These will be extracted into their own widgets
@erdemyerebasmaz
Group AddressWidget widgets under address_widget directory
99f98ed
@erdemyerebasmaz
Unify fee & limits message box widgets
a16a803 
Remove ExpiryAndFeeMessage & LnAddressFeeMessage widgets
@erdemyerebasmaz
Remove ReceiveLiquidAddressPaymentPage
52c92e2
@erdemyerebasmaz
Update messages from Breez-Translations
95e4b8e
@erdemyerebasmaz
Track payments and pop to home page to display bubble animation on re…
da30fc7 
…ceiving payment
@erdemyerebasmaz
Fade out the bubble animation and pop the SuccessfulPaymentRoute
6758d0d 
Replace TransparentPageRoute with PageRouteBuilder.
@erdemyerebasmaz
Support LNURL Withdraw with new UI
1ffdd92 
TODO: Create a dedicated page for LNURL Withdraw with extensions on request data & pre-process the payment to see if it's within payment limits before opening the page.
@erdemyerebasmaz
Display payment received message upon receiving a payment
9eb46e5
@erdemyerebasmaz
Fix the minimum value pasted on clicking limits label on LNURL paymen…
86370da 
…t page
@erdemyerebasmaz
Only track incoming payments
8d2dea1
@erdemyerebasmaz
Fix the flip animation & display it after a delay
c21db61
@erdemyerebasmaz
Refactor AddressWidget
5f6ed3b
@erdemyerebasmaz
Add comments for flip transition animation
a0312ea
@erdemyerebasmaz
Remove didUpdateWidget not to display FlipTransition twice
6f3a73c 
Reduce duration check to 10 seconds
@erdemyerebasmaz
Add padding to payment limits message box loader
69cc341
@erdemyerebasmaz
Display errors for LNURL payments that fall below payment limits
0204ec1 
Refactor LNURLPaymentPage
@erdemyerebasmaz
Use domain from LnUrlPayRequestData on title
5d4ed58
@erdemyerebasmaz
Rename and move address widget folders
f39baa6
@erdemyerebasmaz
Create a dedicated LnUrl Withdraw page
c05c8cb
@erdemyerebasmaz
Display errors for URLs recognized through QR scanner
2f0e79f
@erdemyerebasmaz
Fix auto focus on LnUrlWithdrawPage
da9b4d4
@erdemyerebasmaz
Remove LnUrlWithdraw logic from ReceiveLightningPaymentPage
c59e455
@erdemyerebasmaz
Add a different message if payment amount is outside allowed limits
c99ce76
@erdemyerebasmaz
Refactor LnUrlWithdrawPage & LnUrlPaymentPage
41781d3 
- Wait for ln limits to be fetched on opening LnUrlWithdrawPage & LnUrlPaymentPage
- Rename LNURLPaymentPage to LnUrlPaymentPage
- Apply LnUrlPaymentPage payment limit & error handling logic on LnUrlWithdrawPage
- Simplified LnUrlWithdrawPage
- Removed redundant BlocBuilder's & unused receivePaymentResponse, prepareResponse logic.
@erdemyerebasmaz
Make sure the effective min & max limits are shown & pasted
2f89115
@erdemyerebasmaz
Reorder variable initialization
f556d04
@erdemyerebasmaz
Validate effective limits before updating form fields
6ae0afb
@erdemyerebasmaz
Validate payments against effective limits
499b267 
- Rename LnUrlPayRequestData variable named data to requestData.
- Add KeyboardDoneAction on LnUrlPaymentPage
- Make the widgets on both LnUrl pages more consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez Awaiting requested review from roeierez

@dangeross dangeross Awaiting requested review from dangeross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erdemyerebasmaz @dangeross