Use PageView builder to address performance issues

breez · Sep 9, 2024 · 6a9135b · 6a9135b
1 parent abc9a17
commit 6a9135b
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/lib/routes/receive_payment/receive_payment_page.dart b/lib/routes/receive_payment/receive_payment_page.dart
@@ -26,6 +26,15 @@ class _ReceivePaymentPageState extends State<ReceivePaymentPage> {
     ReceiveBitcoinAddressPaymentPage(),
   ];
 
+  final List<Widget> _memoizedPages = [];
+
+  Widget _getPage(int index) {
+    if (_memoizedPages.length <= index) {
+      _memoizedPages.add(pages[index]);
+    }
+    return _memoizedPages[index];
+  }
+
   @override
   void dispose() {
     pageController.dispose();
@@ -88,11 +97,12 @@ class _ReceivePaymentPageState extends State<ReceivePaymentPage> {
             ),
           ),
           Expanded(
-            child: PageView(
+            child: PageView.builder(
               physics: const NeverScrollableScrollPhysics(),
               controller: pageController,
               onPageChanged: _onPageChanged,
-              children: pages,
+              itemCount: pages.length,
+              itemBuilder: (context, index) => _getPage(index),
             ),
           ),
         ],