This repository has been archived by the owner on May 10, 2024. It is now read-only.
Implement UI for Brave Ads state level targeting #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has been decided that state names will not be localized in the MVP |
tmancey
force-pushed
the
brave-core-1.12.x-ios-state-level-targeting
branch
from
87d74ff
to
fb52c11
Compare
kylehickinson
suggested changes
Jun 16, 2020
Comment on lines
224
to
225
| static let adsSubdivisionTargeting = NSLocalizedString("BraveRewardsAdsSubdivisionTargeting", bundle: .rewardsUI, value: "State level ad targeting", comment: "") | ||
| static let adsSubdivisionTargetingTitle = NSLocalizedString("BraveRewardsAdsSubdivisionTargetingTitle", bundle: .rewardsUI, value: "State level ad targeting", comment: "") |
There was a problem hiding this comment.
These two strings have the same value. There a reason for having both?
| cell.label.text = Strings.adsSubdivisionTargeting | ||
|
|
||
| var adsSubdivisionTargetingCode: String | ||
| if state.ads.subdivisionTargetingCode == "DISABLED" { |
There was a problem hiding this comment.
Is there no const definition of this on ads library side that can be used to avoid string-checking here and L232?
There was a problem hiding this comment.
Not at this time, however, I will raise a new issue to add an API call to detect if disabled. So recommended we add at a future date, thanks
tmancey
force-pushed
the
brave-core-1.12.x-ios-state-level-targeting
branch
2 times, most recently
from
bf2011e
to
c2205ac
Compare
tmancey
force-pushed
the
brave-core-1.12.x-ios-state-level-targeting
branch
from
c2205ac
to
ea51dec
Compare
kylehickinson
approved these changes
Jun 16, 2020
kylehickinson
pushed a commit
that referenced
this pull request
Jun 16, 2020
kylehickinson
added a commit
that referenced
this pull request
Jun 23, 2020
tmancey
pushed a commit
that referenced
this pull request
Jul 7, 2020
kylehickinson
added a commit
that referenced
this pull request
Jul 9, 2020
kylehickinson
added a commit
that referenced
this pull request
Jul 27, 2020
kylehickinson
added a commit
that referenced
this pull request
Jul 27, 2020
kylehickinson
added a commit
that referenced
this pull request
Jul 30, 2020
kylehickinson
added a commit
that referenced
this pull request
Jul 30, 2020
kylehickinson
added a commit
that referenced
this pull request
Aug 5, 2020
kylehickinson
added a commit
that referenced
this pull request
Aug 13, 2020
kylehickinson
added a commit
that referenced
this pull request
Aug 14, 2020
Brandon-T
added a commit
that referenced
this pull request
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #2636
Submitter Checklist:
NSLocalizableString()Test Plan:
See brave/brave-browser#9200
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement