Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement state level ads delivery #2636

Closed
tmancey opened this issue Jun 16, 2020 · 3 comments
Closed

Implement state level ads delivery #2636

tmancey opened this issue Jun 16, 2020 · 3 comments
Assignees
@tmancey
Labels
enhancement Epic: Ads QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.21

Comments

@tmancey
Copy link
Collaborator

tmancey commented Jun 16, 2020

brave/brave-browser#9200
@tmancey tmancey self-assigned this Jun 16, 2020
@tmancey tmancey mentioned this issue Jun 16, 2020
Merged
7 tasks
@tmancey tmancey added this to the 1.20 milestone Jun 16, 2020
kylehickinson pushed a commit that referenced this issue Jun 16, 2020
@tmancey
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
2643cf9
kylehickinson pushed a commit that referenced this issue Jun 16, 2020
@tmancey @kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
7b538ef
kylehickinson added a commit that referenced this issue Jun 23, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
f5f1077
tmancey pushed a commit that referenced this issue Jul 7, 2020
@kylehickinson @tmancey
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
48b7405
kylehickinson added a commit that referenced this issue Jul 9, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
7ec6bac
kylehickinson added a commit that referenced this issue Jul 27, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
03fc207
kylehickinson added a commit that referenced this issue Jul 27, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
aecb14e
kylehickinson added a commit that referenced this issue Jul 30, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
257bd0a
kylehickinson added a commit that referenced this issue Jul 30, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
ce3a6ee
kylehickinson added a commit that referenced this issue Aug 5, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
a3eb69f
kylehickinson added a commit that referenced this issue Aug 13, 2020
@kylehickinson
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
610138b
Brandon-T added a commit that referenced this issue Sep 25, 2020
@Brandon-T
Fix #2636: Implement UI for Brave Ads state level targeting (#2637)
791c72b
@srirambv
Copy link
Contributor

@tmancey can you please add iOS specific test plan for this issue?

@tmancey
Copy link
Collaborator Author

tmancey commented Nov 5, 2020

@srirambv iOS works same as desktop. For United States state level targeting will appear in the Ads UI. Ads for the United States which are part of a subdivision (i.e. FL, NY etc.) should only be show if you are in those regions. Thanks

@kjozwiak
Copy link
Member

kjozwiak commented Nov 6, 2020 •
edited
Loading

  • Verification PASSED on iPad Air (3rd Gen) on iOS 14.0.1 using 1.21 (20.11.2.20)
Settings Received Ad Total Count
Screen Shot 2020-11-05 at 11 22 57 PM IMG_0167 Screen Shot 2020-11-05 at 11 23 07 PM
  • Verification PASSED on iPhone 11 on iOS 14.1 using 1.21 (20.11.2.20)
Settings Received Ad Total Count
Screen Shot 2020-11-05 at 11 22 57 PM 9EC3109F-4513-4642-B476-00466691150F Screen Shot 2020-11-05 at 11 23 07 PM
  • Verification PASSED on iPad Mini 4 on iOS 13.7 using 1.21 (20.11.2.20)
Settings Received Ad Total Count
Screen Shot 2020-11-05 at 11 22 57 PM IMG_0358 Screen Shot 2020-11-05 at 11 23 07 PM

Prerequisites for the below cases:

  • iOS region set to US
  • connected to US VPN and selecting IL

STR/Cases used

  • ensured that IL is automatically selected via State level ad targeting (due to being connected to IL VPN)
  • ensured that a state level ad is delivered without any issues and appears under Ad notifications received this month
  • double checked with @tmancey and ensured

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tmancey tmancey

Labels
enhancement Epic: Ads QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21
Development

No branches or pull requests
4 participants
@tmancey @kjozwiak @NejcZdovc @srirambv