Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Unstoppable Domain navigation #7089

Closed
StephenHeaps opened this issue Mar 14, 2023 · 1 comment · Fixed by #7165
Closed

Unstoppable Domain navigation #7089

StephenHeaps opened this issue Mar 14, 2023 · 1 comment · Fixed by #7165
Assignees
@StephenHeaps
Labels
enhancement Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.50

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Mar 14, 2023 •
edited
Loading

Description:

iOS version of
brave/brave-browser#15158

Implement navigating to Unstoppable domains in the browser via omnibar / url bar. The default should be to ask the user before navigating via an interstitial page.

Supported extensions: https://github.com/brave/brave-core/blob/master/components/brave_wallet_ui/common/constants/domain-extensions.ts

Terms of Use: https://consensys.net/terms-of-use/
Privacy Policy: https://consensys.net/privacy-policy/

Interstitial:
Unstoppable Domains interstitial

Wallet address resolution will be handled in #6182
@StephenHeaps StephenHeaps self-assigned this Mar 14, 2023
@StephenHeaps StephenHeaps mentioned this issue Mar 15, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Mar 28, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Apr 11, 2023
@StephenHeaps
Fix #7089: Unstoppable Domains Navigation (#7165)
198a78b 
* Support resolving unstoppable domains in omnibox

* Replace `.888` with `.zil` in supportedUDExtensions.
@iccub iccub added this to the 1.50 milestone Apr 11, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.50 (24.417.16)

  • Verified steps from #7165
  • Verified navigating to UD domain brings up the interstitial page
  • Verified Terms of use and Privacy Policy points to Consensys (Infura) pages
  • Verified clicking on Proceed using Infura server loads the IPFS interstitial page if its set to Ask else loads the page using specified public gateway
  • Verified UD domain resolution only works on normal tabs and not on private tabs
iPhone 7+ (iOS 15.7.3) iPad Pro (iOS 16.5 Beta)
7089-iPhone.7+.MP4
7089-iPad.Pro.MP4

@Uni-verse Uni-verse mentioned this issue May 5, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7089: Unstoppable Domains Navigation (brave/brave…
9611869 
…-ios#7165)

* Support resolving unstoppable domains in omnibox

* Replace `.888` with `.zil` in supportedUDExtensions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
enhancement Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50
Development

Successfully merging a pull request may close this issue.

Fix #7089: Unstoppable Domains Navigation brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv