Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolution of unstoppable domains with IPFS records via Ethereum #15158

Closed
yrliou opened this issue Apr 6, 2021 · 2 comments · Fixed by brave/brave-core#8456
Closed

Comments

@yrliou
Copy link
Member

yrliou commented Apr 6, 2021

Description

This issue is to track adding support of resolution of unstoppable domains with IPFS records via Ethereum network directly.
We'll be calling ProxyReader.GetMany from Unstoppable Domains to retrieve IPFS records and redirect to the target IPFS URI.
After that, IPFS support in Brave will take over the rest.

@yrliou yrliou self-assigned this Apr 6, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 9, 2021
@yrliou yrliou added this to the 1.25.x - Nightly milestone Apr 15, 2021
@stephendonner
Copy link

Verified PASSED using the testplan from brave/brave-core#8456 on build

Brave 1.25.22 Chromium: 90.0.4430.72 (Official Build) nightly (x86_64)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. Went to settings, opened drop-down of ENS resolve method settings, and verified it did NOT have Ethereum.
  2. Changed the resolve method of Unstoppable Domains to Ethereum
  3. Went to brave://settings/ipfs, set the Method to resolve to Gateway
  4. Visited brave.crypto and confirmed the URL https://bafybeid6rntsjiydicxj5cnmnqonbvwv35lrjgd6dngskptra3oa2otxxm.ipfs.dweb.link/ was loaded via IPFS
example example example
Screen Shot 2021-04-16 at 12 32 54 PM Screen Shot 2021-04-16 at 12 33 16 PM Screen Shot 2021-04-16 at 12 34 14 PM

@srirambv
Copy link
Contributor

srirambv commented May 6, 2021

Verification passed on

Brave 1.25.53 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Windows 10 OS Version 2009 (Build 19042.867)
  • Verified Ethereum is an option under Unstoppable Domain resolution
    image
  • Verified ENS doesn't have an entry for Ethereum in dropdown
    image
  • Verified setting UD to resolve via Ethereum and setting IPFS to gateway loads the page using IPFS Public gateway(dweb.link)
image image

Verification passed on

Brave 1.25.53 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Linux
  • Verified Ethereum is an option under Unstoppable Domain resolution
    image

  • Verified ENS doesn't have an entry for Ethereum in dropdown
    image

  • Verified setting UD to resolve via Ethereum and setting IPFS to gateway loads the page using IPFS Public gateway(dweb.link)

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants