Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tor log from disk to memory (uplift to 1.27.x) #9380

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 8, 2021

Uplift of #9346
Resolves brave/brave-browser#16747

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team July 8, 2021 23:26
@brave-builds brave-builds self-assigned this Jul 8, 2021
@brave-builds brave-builds added this to the 1.27.x - Beta milestone Jul 8, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2021

Restarting iOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr9346_tor-log-in-mem_1.27.x-ios/1/execution/node/139/log/

 FAILED: gen/brave/vendor/brave-ios/ads.mojom.objc.h gen/brave/vendor/brave-ios/ads.mojom.objc+private.h gen/brave/vendor/brave-ios/ads.mojom.objc.mm gen/brave/vendor/brave-ios/objc_templates_bytecode/ads_objc_templates.zip 

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.27.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9346 (comment).

@kjozwiak kjozwiak merged commit 6782182 into 1.27.x Jul 9, 2021
@kjozwiak kjozwiak deleted the pr9346_tor-log-in-mem_1.27.x branch July 9, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants