Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] #1249056 Tor log #16747

Closed
darkdh opened this issue Jul 1, 2021 · 3 comments · Fixed by brave/brave-core#9346
Closed

[hackerone] #1249056 Tor log #16747

darkdh opened this issue Jul 1, 2021 · 3 comments · Fixed by brave/brave-core#9346
Assignees
@darkdh
Labels
feature/tor OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include security
Milestone
1.27.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Jul 1, 2021

https://hackerone.com/reports/1249056

We need to get rid of the disk tor.log and then replace them with control channel events

SETEVENTS NOTICE, SETEVENTS WARN and SETEVENTS ERR with or without timestamp
@darkdh darkdh self-assigned this Jul 2, 2021
@diracdeltas diracdeltas added feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 6, 2021
@darkdh darkdh mentioned this issue Jul 6, 2021
Merged
24 tasks
@darkdh darkdh added this to the 1.28.x - Nightly milestone Jul 7, 2021
@stephendonner
Copy link

Hi @darkdh; given this has a test plan (thanks!), is it QA/Yes?

@darkdh
Copy link
Member Author

darkdh commented Jul 8, 2021

@stephendonner yeah, I forgot to added QA related labels, added!

@brave-builds brave-builds mentioned this issue Jul 8, 2021
Merged
7 tasks
@stephendonner
Copy link

stephendonner commented Jul 12, 2021 •
edited by btlechowski
Loading

Verified PASSED using

Brave 1.27.101 Chromium: 91.0.4472.124 (Official Build) beta (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)

Tor log check:

  1. new profile
  2. launched Brave beta
  3. opened brave://tor-internals and went to the Logs tab
  4. opened https://brave5t5rjjg3s6k.onion/ in a New Private Window with Tor
  5. took note of NOTICE and WARN logged info/warnings, without timestamps
  6. checked /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser-Beta for the presence of a tor.log file; confirmed there was none
example example example example
Screen Shot 2021-07-12 at 11 13 10 AM Screen Shot 2021-07-12 at 11 13 14 AM Screen Shot 2021-07-12 at 11 14 42 AM Screen Shot 2021-07-12 at 11 15 34 AM

Tor log migration:

  1. launched 1.26.74
  2. opened https://brave5t5rjjg3s6k.onion/ in a New Private Window with Tor
  3. quit Brave
  4. deleted Brave-Browser-Beta profile folder
  5. renamed 1.26.74 profile folder from Brave-Browser to Brave-Browser-Beta
  6. confirmed the above folder had a previous tor.log file
  7. launched Brave beta with the above folder
  8. opened https://brave5t5rjjg3s6k.onion/ in a New Private Window with Tor
  9. saw tor.log disappear from disk
example example example example
Screen Shot 2021-07-12 at 11 14 21 AM Screen Shot 2021-07-12 at 11 24 16 AM Screen Shot 2021-07-12 at 11 25 41 AM Screen Shot 2021-07-12 at 11 26 42 AM

Verified PASSED using

Brave 1.27.102 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2009 (Build 22000.65)

Tor log check:

  1. new profile
  2. launched Brave beta
  3. opened brave://tor-internals and went to the Logs tab
  4. opened https://brave5t5rjjg3s6k.onion/ in a New Private Window with Tor
  5. took note of NOTICE and WARN logged info/warnings, without timestamps
  6. checked Stephen/AppData/Local/BraveSoftware/Brave-Browser-Beta for the presence of a tor.log file; confirmed there was none
example example example
brave-site tor-internals empty-tor

Tor log migration:

  1. launched 1.26.74
  2. opened https://brave5t5rjjg3s6k.onion/ in a New Private Window with Tor
  3. quit Brave
  4. deleted Brave-Browser-Beta profile folder
  5. renamed 1.26.74 profile folder from Brave-Browser to Brave-Browser-Beta
  6. confirmed the above folder had a previous tor.log file
  7. launched Brave beta with the above folder
  8. opened https://brave5t5rjjg3s6k.onion/ in a New Private Window with Tor
  9. saw tor.log disappear from disk
example example example
brave-site-2nd-step previous-tor-log tor-log-gone

Verification passed on

Brave 1.27.101 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Linux

Tor log check:

image image image

Tor log migration:

image image

@LaurenWags LaurenWags mentioned this issue Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/tor OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Migrate tor log from disk to memory brave/brave-core
6 participants
@stephendonner @diracdeltas @kjozwiak @darkdh @LaurenWags @btlechowski